1567951 - Add implicit rollback to setRemoteDescription(offer) per spec.

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Per w3c/webrtc-pc#2212.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1567951: Add implicit rollback in setRemoteDescription(offer).

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1567951: Test implicit rollback in SRD(offer).

Depends on D38889

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/092e24332c39
Add implicit rollback in setRemoteDescription(offer). r=bwc
https://hg.mozilla.org/integration/autoland/rev/ca95add81105
Test implicit rollback in SRD(offer). r=bwc

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18010 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for mda failures on test_peerConnection_setRemoteOfferInHaveLocalOffer.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/52901bda6085ab760c34412e929e7fb00ad9a6e4
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257922055&repo=autoland&lineNumber=46881

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b1d51cda77c
Add implicit rollback in setRemoteDescription(offer). r=bwc
https://hg.mozilla.org/integration/autoland/rev/84386d8e67af
Test implicit rollback in SRD(offer). r=bwc

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/3b1d51cda77c
https://hg.mozilla.org/mozilla-central/rev/84386d8e67af

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 12

[Eric Shepherd [:sheppy]]

For documentation purposes, we need to tweak some of the discussion and possibly sample code around negotiation slightly here.

Comment 13

[Eric Shepherd [:sheppy]]

Documentation updates:

• Text updates to setRemoteDescription() are completed
• Listed on Firefox 70 for developers
• BCD PR 5018 submitted to update compatibility database to include an entry for "implicit_rollback".

The sample code and general tutorial text updates that need to be made for perfect negotiation will all happen at once after all of the required changes have been implemented. See the perfect negotiation doc updates issue on the doc team issue tracker for details.