1568275 - Windows Security settings are missing lockpref items (not properly mapped to a preference.)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[register]

Attachment: ff-1.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.142 Safari/537.36

Steps to reproduce:

Attempted to use lockpref settings for the following items:

:" Block dangerous and deceptive content."
: "Block dangerous downloads"
: "Warn me about unwanted and uncommon software."

Actual results:

These settings will not lock down as expected.

Expected results:

These settings should have locked down

Comment 1

[Mike Kaply [:mkaply]]

I've verified this.

Comment 2

[Mike Kaply [:mkaply]]

This is really painful because these checkboxes affect multiple prefs.

Block dangerous and deceptive content sets:

browser.safebrowsing.malware.enabled
browser.safebrowsing.phishing.enabled

Warn me about unwanted and uncommon software sets:

browser.safebrowsing.downloads.remote.block_potentially_unwanted
browser.safebrowsing.downloads.remote.block_uncommon

So I'm guessing if either one of these is locked, we should lock the preference?

Block dangerous downloads is browser.safebrowsing.downloads.enabled

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Bug 1568275 - Disable deceptive content prefs when locked.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c981e973da9
Disable deceptive content prefs when locked. r=preferences-reviewers,Gijs

Comment 5

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/0c981e973da9

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 9273488 [details]
Bug 1568275 - Disable deceptive content prefs when locked.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Parity with Firefox beta
• User impact if declined: Preferences UI doesn't match locked prefs
• Fix Landed on Version: 102
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Automated test. Only happens when prefs are locked.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9273488 [details]
Bug 1568275 - Disable deceptive content prefs when locked.

Approved for 91.11esr.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr91/rev/5d77dfedefb2