Closed
Bug 1568281
Opened 7 years ago
Closed 7 years ago
Stop implementing JS-exposed QueryInterface on DOMParser
Categories
(Core :: DOM: Core & HTML, task)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
DOMParser doesn't actually QI to anything other than nsISupports, and if I add a MOZ_CRASH in dom::QueryInterface when the object is a DOMParser that crash is not hit. See https://treeherder.mozilla.org/#/jobs?repo=try&revision=2626ecb8dd92ed7ae0a6eacc78a3d019507ddc1b
I don't know whether Thunderbird might be doing QI on DOMParser, though I would assume it's not.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
||
Comment 2•7 years ago
|
||
All the DOMParsers we have were converted from nsIDOMParser. We do new DOMParser(). I can't see any QI in the vicinity:
https://searchfox.org/comm-central/search?q=DOMParser&case=false®exp=false&path=mail
|
|
Assignee | |
Updated•7 years ago
|
Summary: Stop implementing QueryInterface on DOMParser → Stop implementing JS-exposed QueryInterface on DOMParser
|
||
Updated•7 years ago
|
Attachment #9080112 -
Attachment description: Bug 1568281. Stop implementing QueryInterface on DOMParser. r=peterv → Bug 1568281. Stop implementing JS-exposed QueryInterface on DOMParser. r=peterv
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6823165abe1c
Stop implementing JS-exposed QueryInterface on DOMParser. r=peterv
|
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•