1568306 - Update about:logins dialog styling to match the spec

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P1)

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1568306 - Update about:logins dialog styling to match the spec. r=jaws

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1568306 - Update about:logins dialog strings to match the spec

Depends on D39103

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/044beb95c8fc
Update about:logins dialog styling to match the spec. r=jaws

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures on test_confirm_delete_dialog.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/66503e8c6f26ecea382baaea7bee19826efc7601
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258014109&repo=autoland&lineNumber=1445

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d7df4760fe4
Update about:logins dialog styling to match the spec. r=jaws
https://hg.mozilla.org/integration/autoland/rev/585b6ae0dd0d
Update about:logins dialog strings to match the spec r=fluent-reviewers,jaws,Pike

Comment 6

[Cristina Coroiu [:ccoroiu]]

Backed out 2 changesets (bug 1568306) for browser-chrome failures at browser/components/aboutlogins/tests/browser/browser_confirmDeleteDialog.js

Backout: https://hg.mozilla.org/integration/autoland/rev/0552b7cfd6bf3623357a20dbd5b63fdde1d538df

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=585b6ae0dd0d59e88b882fccfceeddcd6e89229b

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258155527&repo=autoland&lineNumber=6786

[task 2019-07-24T18:49:44.252Z] 18:49:44 INFO - TEST-START | browser/components/aboutlogins/tests/browser/browser_confirmDeleteDialog.js
[task 2019-07-24T18:49:44.255Z] 18:49:44 INFO - GECKO(1761) | ++DOCSHELL 0x127d26000 == 2 [pid = 1765] [id = {ac7b6bb8-7955-ec49-a173-175bbf144a56}]
[task 2019-07-24T18:49:44.255Z] 18:49:44 INFO - GECKO(1761) | ++DOMWINDOW == 4 (0x10fcc9020) [pid = 1765] [serial = 4] [outer = 0x0]
[task 2019-07-24T18:49:44.289Z] 18:49:44 INFO - GECKO(1761) | [Child 1765, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
[task 2019-07-24T18:49:44.289Z] 18:49:44 INFO - GECKO(1761) | ++DOMWINDOW == 5 (0x127be3000) [pid = 1765] [serial = 5] [outer = 0x10fcc9020]
[task 2019-07-24T18:49:44.289Z] 18:49:44 INFO - GECKO(1761) | [Child 1765, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
[task 2019-07-24T18:49:44.292Z] 18:49:44 INFO - GECKO(1761) | [Parent 1761, Main Thread] WARNING: Constructing RangeBoundary with invalid value: 'mRef || aOffset == 0', file /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RangeBoundary.h, line 79
[task 2019-07-24T18:49:44.292Z] 18:49:44 INFO - GECKO(1761) | [Parent 1761, Main Thread] WARNING: Constructing RangeBoundary with invalid value: 'mRef || aOffset == 0', file /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/RangeBoundary.h, line 79
[task 2019-07-24T18:49:44.292Z] 18:49:44 INFO - GECKO(1761) | ++DOMWINDOW == 6 (0x127be6400) [pid = 1765] [serial = 6] [outer = 0x10fcc9020]
[task 2019-07-24T18:49:44.293Z] 18:49:44 INFO - GECKO(1761) | [Child 1765, Main Thread] WARNING: NS_ENSURE_SUCCESS(mStatus, *this) failed with result 0x80004005: file /builds/worker/workspace/build/src/obj-firefox/dist/include/nsIURIMutator.h, line 489
[task 2019-07-24T18:49:44.520Z] 18:49:44 INFO - GECKO(1761) | [1766, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 194
[task 2019-07-24T18:49:44.521Z] 18:49:44 INFO - GECKO(1761) | [1766, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 194
[task 2019-07-24T18:49:44.521Z] 18:49:44 INFO - GECKO(1761) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /var/folders/p7/rbf4_txd3vs20v5xbysjqk1h000017/T/tmpXDrjqG.mozrunner/runtests_leaks_tab_pid1766.log
[task 2019-07-24T18:49:44.521Z] 18:49:44 INFO - GECKO(1761) | [1766, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 194
[task 2019-07-24T18:49:44.521Z] 18:49:44 INFO - GECKO(1761) | [1766, MainThread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 194
[task 2019-07-24T18:49:45.104Z] 18:49:45 INFO - GECKO(1761) | [Child 1765, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
[task 2019-07-24T18:49:45.168Z] 18:49:45 INFO - TEST-INFO | started process screencapture
[task 2019-07-24T18:49:45.299Z] 18:49:45 INFO - TEST-INFO | screencapture: exit 0
[task 2019-07-24T18:49:45.301Z] 18:49:45 INFO - Buffered messages logged at 18:49:44
[task 2019-07-24T18:49:45.301Z] 18:49:45 INFO - Entering test bound setup
[task 2019-07-24T18:49:45.301Z] 18:49:45 INFO - Buffered messages logged at 18:49:45
[task 2019-07-24T18:49:45.301Z] 18:49:45 INFO - Leaving test bound setup
[task 2019-07-24T18:49:45.302Z] 18:49:45 INFO - Entering test bound test
[task 2019-07-24T18:49:45.302Z] 18:49:45 INFO - Buffered messages finished
[task 2019-07-24T18:49:45.302Z] 18:49:45 INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_confirmDeleteDialog.js | Title contents should match l10n attribute set on outer element - "Delete this login?" == "Confirm Deletion" -
[task 2019-07-24T18:49:45.302Z] 18:49:45 INFO - Stack trace:
[task 2019-07-24T18:49:45.302Z] 18:49:45 INFO - resource://testing-common/content-task.js line 62 > eval:null:16
[task 2019-07-24T18:49:45.302Z] 18:49:45 INFO - resource://testing-common/content-task.js:null:63
[task 2019-07-24T18:49:45.302Z] 18:49:45 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-07-24T18:49:45.308Z] 18:49:45 INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_confirmDeleteDialog.js | Message contents should match l10n attribute set on outer element - "This action cannot be undone." == "Are you sure you want to delete this login?" -
[task 2019-07-24T18:49:45.308Z] 18:49:45 INFO - Stack trace:
[task 2019-07-24T18:49:45.308Z] 18:49:45 INFO - resource://testing-common/content-task.js line 62 > eval:null:21
[task 2019-07-24T18:49:45.308Z] 18:49:45 INFO - resource://testing-common/content-task.js:null:63
[task 2019-07-24T18:49:45.308Z] 18:49:45 INFO - TEST-PASS | browser/components/aboutlogins/tests/browser/browser_confirmDeleteDialog.js | Cancel button contents should match l10n attribute set on outer element - "Cancel" == "Cancel" -
[task 2019-07-24T18:49:45.308Z] 18:49:45 INFO - Not taking screenshot here: see the one that was previously logged

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7736bdf10995
Update about:logins dialog styling to match the spec. r=jaws
https://hg.mozilla.org/integration/autoland/rev/4fb0e3173f8d
Update about:logins dialog strings to match the spec r=fluent-reviewers,jaws,Pike

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7736bdf10995
https://hg.mozilla.org/mozilla-central/rev/4fb0e3173f8d