1568353 - Some FxA related network requests never timeout

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect, P1)

Description

[wb0gaz]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Windows 7 32-bit , firefox 68.0.1 32-bit - machine frequently goes through suspend cycles with firefox running.

Workaround - exit then restart firefox (fixes this issue every time.)

This problem has existed for some months at least (noticed it first when I discovered that my intended data - bookmarks - was not propagating across machines all logged into the same firefox account.)

Actual results:

Firefox sometimes (frequently) ends up with "syncing.." continuously active, and no sync update is occurring.

Expected results:

"syncing..." software should detect that it is in this state with no productive data transfer, and restart the underlying activity.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Thanks for reporting this and I'm sorry sync is misbehaving for you.

Are you sure this is related to sleep/suspend, or could it just happen at seemingly "random" times? Eg, we have bug 1483976 (which we don't really understand yet) and that doesn't seem to be related to sleep or suspend (although maybe it is) - the more details we can get, the better.

Something that would be very helpful is:

• Install the about:sync addon from https://addons.mozilla.org/en-US/firefox/addon/about-sync/
• When you next reproduce the problem, open about:sync, and in the "Log files and diagnostics" session, click the "Force a new (probably empty) log now".
• Use about:sync to create a .zip file of all your sync logs, and email the .zip file to me via the address I use for bugzilla.

Thanks!

Comment 3

[Mark Hammond [:markh] [:mhammond]]

I got the logs and they demonstrate that some of the requests we make appear to block forever and never time out. This should be easy to fix - thanks!

Comment 4

[Mark Hammond [:markh] [:mhammond]]

rest.js already supports a timeout - it just defaults to not specifying one! It even has tests. The only consumers of rest.js left in the tree are FxAccounts related, so I think the right thing to do is just default all consumers of rest.js to a 5 minute timeout (the same Sync uses for its resources). I'll request review from :rfkelly as it's all FxA requests which are affected.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1568353 - set the default rest.js timeout to be 5 minutes. r?rfkelly

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85943ff078d9
set the default rest.js timeout to be 5 minutes. r=rfkelly

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/85943ff078d9