1568419 - Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

Created by Bug 1567737 Comment 6.

Since Bug 1562616 fix, GPUVideoTextureHost::NumSubTextures() could return 0, if mWrappedTextureHost does not exist. This case is not handled correctly in AsyncImagePipelineManager::UpdateImageKeys(). It could cause a crash by InvalidArrayIndex_CRASH().

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1568419 - Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys()

Comment 2

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8e532b353798e4b03e51c05f8690df146a9b0bf

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1da5a37de0fd
Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys() r=nical

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/1da5a37de0fd

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval if you're comfortable doing so.

Comment 6

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9080238 [details]
Bug 1568419 - Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys()

Beta/Release Uplift Approval Request

• User impact if declined: It might cause a crash in gpu process during playing video
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is simple enough.
• String changes made/needed: None

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9080238 [details]
Bug 1568419 - Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys()

Fixes a GPU process crash when WebRender is enabled. Approved for 69.0b9.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/03ecebbe614d