Closed
Bug 1568419
Opened 5 years ago
Closed 5 years ago
Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys()
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | unaffected |
| firefox68 | --- | unaffected |
| firefox69 | --- | fixed |
| firefox70 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Created by Bug 1567737 Comment 6.
Since Bug 1562616 fix, GPUVideoTextureHost::NumSubTextures() could return 0, if mWrappedTextureHost does not exist. This case is not handled correctly in AsyncImagePipelineManager::UpdateImageKeys(). It could cause a crash by InvalidArrayIndex_CRASH().
|
Assignee | |
Updated•5 years ago
|
Type: enhancement → defect
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Keywords: regression
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by sikeda.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1da5a37de0fd Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys() r=nical
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
|
||
Comment 5•5 years ago
|
||
Please nominate this for Beta approval if you're comfortable doing so.
status-firefox68:
--- → unaffected
status-firefox69:
--- → affected
status-firefox-esr60:
--- → unaffected
status-firefox-esr68:
--- → unaffected
Flags: needinfo?(sotaro.ikeda.g)
|
|
Assignee | |
Comment 6•5 years ago
|
||
Comment on attachment 9080238 [details]
Bug 1568419 - Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys()
Beta/Release Uplift Approval Request
- User impact if declined: It might cause a crash in gpu process during playing video
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The change is simple enough.
- String changes made/needed: None
Flags: needinfo?(sotaro.ikeda.g)
Attachment #9080238 -
Flags: approval-mozilla-beta?
|
|
||
Comment 7•5 years ago
|
||
Comment on attachment 9080238 [details]
Bug 1568419 - Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys()
Fixes a GPU process crash when WebRender is enabled. Approved for 69.0b9.
Attachment #9080238 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
|
||
Comment 8•5 years ago
|
||
| bugherder uplift | ||
|
|
||
Updated•2 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•