Closed Bug 1568419 Opened 4 months ago Closed 4 months ago

Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys()

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- fixed
firefox70 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Created by Bug 1567737 Comment 6.

Since Bug 1562616 fix, GPUVideoTextureHost::NumSubTextures() could return 0, if mWrappedTextureHost does not exist. This case is not handled correctly in AsyncImagePipelineManager::UpdateImageKeys(). It could cause a crash by InvalidArrayIndex_CRASH().

Type: enhancement → defect
Regressed by: 1562616
Blocks: 1567737
Assignee: nobody → sotaro.ikeda.g
Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1da5a37de0fd
Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys() r=nical
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Please nominate this for Beta approval if you're comfortable doing so.

Flags: needinfo?(sotaro.ikeda.g)

Comment on attachment 9080238 [details]
Bug 1568419 - Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys()

Beta/Release Uplift Approval Request

  • User impact if declined: It might cause a crash in gpu process during playing video
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change is simple enough.
  • String changes made/needed: None
Flags: needinfo?(sotaro.ikeda.g)
Attachment #9080238 - Flags: approval-mozilla-beta?

Comment on attachment 9080238 [details]
Bug 1568419 - Handle a case that NumSubTextures() returns 0 in AsyncImagePipelineManager::UpdateImageKeys()

Fixes a GPU process crash when WebRender is enabled. Approved for 69.0b9.

Attachment #9080238 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.