1568446 - Cherry-pick servo/servo#23824

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

That removes std::mem::uninitialized usage.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c30e18adac2
Add UniqueArc::new_uninit, UniqueArc::assume_init. r=emilio
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e7267a5b743
Replace uses of mem::uninitialized with MaybeUninit. r=emilio

Comment 2

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bb4a4d46f2e
Backed out 2 changesets for causing multiple failures

Comment 3

[Alexandru Michis [:malexandru]]

Backed out 2 changesets (Bug 1568446) for causing multiple failures.

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/9bb4a4d46f2ecd189354a409e02f9edc5ca0df35

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=6e7267a5b74329c22ddf2b1358a3a144741339dc&selectedJob=258063631

Failure logs:

• REFTEST PROCESS-CRASH | remoteautomation.py | application crashed [@ nsCOMPtr<nsIRunnable>::Assert_NoQueryNeeded()]
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258063631&repo=mozilla-inbound&lineNumber=1539

• PROCESS-CRASH | org.mozilla.geckoview.test.WebExecutorTest.testCookies | application crashed [@ mozilla::StyleGenericUrlOrNone<mozilla::StyleComputedUrl>::StyleGenericUrlOrNone(mozilla::StyleGenericUrlOrNone<mozilla::StyleComputedUrl> const&)]
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258063961&repo=mozilla-inbound&lineNumber=1363

• run failures:
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258063961&repo=mozilla-inbound&lineNumber=1363
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258063513&repo=mozilla-inbound&lineNumber=1287
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258064638&repo=mozilla-inbound&lineNumber=473

• AddressSanitizer: SEGV /builds/worker/workspace/build/src/third_party/rust/indexmap/src/map.rs:826 in indexmap::map::IndexMap$LT$K$C$V$C$S$GT$::find::habc289af7b87c19a
  https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258064120&repo=mozilla-inbound&lineNumber=1451
  And multiple other failures, you can see them all in the treeherder link above.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4542e3d80a9
Add UniqueArc::new_uninit, UniqueArc::assume_init. r=emilio
https://hg.mozilla.org/integration/autoland/rev/414d4ed825e2
Replace uses of mem::uninitialized with MaybeUninit. r=emilio
https://hg.mozilla.org/integration/autoland/rev/237eb34e0758
Don't insta-free in UniqueArc::assume_init. r=SimonSapin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dd904ba01b5
followup: Properly refcount-log UniqueArcs created with new_uninitialized().

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1568446 - followup: Properly refcount-log UniqueArcs created with new_uninitialized().

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/e4542e3d80a9
https://hg.mozilla.org/mozilla-central/rev/414d4ed825e2
https://hg.mozilla.org/mozilla-central/rev/237eb34e0758
https://hg.mozilla.org/mozilla-central/rev/5dd904ba01b5