1568521 - Tracking protection doorhanger's Enable/Disable states don't work

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Andrei Lazar]

This is a regression caused by bug 1330467 where URI was replaced by principal.

Comment 1

[Andrei Lazar]

Attachment: Bug 1568521 Tracking protection doorhanger's Enable/Disable states don't work r=VladBaicu

Now using lastURI instead of principal and now we are using the right functions in order to test permissions.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3eff9a10cc58
Tracking protection doorhanger's Enable/Disable states don't work r=VladBaicu

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3eff9a10cc58

Comment 4

[Stefan Deiac]

Hello, I tested this ticket on the latest Nightly 70.0a1 (2019-07-26) and I can't reproduce the problem.
Devices:

• Nokia 6 (Android 7.1.1);
• Samsung Galaxy S8 (Android 9);
• Google Pixel (Android Q).
  Due to that, I'll mark this issue as verified, thanks.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Is bug 1330467 something we had on the radar for ESR68 uplift?

Comment 6

[Andrei Lazar]

Hey Ryan, I would provide you with an answer if I knew, but unfortunately I'm not the right person to ask this question. Perhaps Chris can address this question.

Comment 7

[Chris Peterson [:cpeterson]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

Is bug 1330467 something we had on the radar for ESR68 uplift?

Tom or Arthur, will privacy.firstparty.isolate bug 1330467 be uplifted to Firefox ESR 68 (for Tor)? Tom mentioned ESR in bug 1330467 comment 51.

If so, then we'll also need to uplift this Fennec regression fix to ESR 68.

Comment 8

[Tom Ritter [:tjr]]

I flagged Gary to answer this question.

Comment 9

[Gary Chen [:xeonchen]]

(In reply to Chris Peterson [:cpeterson] from comment #7)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

Is bug 1330467 something we had on the radar for ESR68 uplift?

Tom or Arthur, will privacy.firstparty.isolate bug 1330467 be uplifted to Firefox ESR 68 (for Tor)? Tom mentioned ESR in bug 1330467 comment 51.

If so, then we'll also need to uplift this Fennec regression fix to ESR 68.

Sorry for late reply...
I'm okay to uplift bug 1330467 since regressions caused by it only happen when FPI is enabled.

Comment 10

[Chris Peterson [:cpeterson]]

(In reply to Gary Chen [:xeonchen] from comment #9)

(In reply to Chris Peterson [:cpeterson] from comment #7)

Tom or Arthur, will privacy.firstparty.isolate bug 1330467 be uplifted to Firefox ESR 68 (for Tor)? Tom mentioned ESR in bug 1330467 comment 51.
...
I'm okay to uplift bug 1330467 since regressions caused by it only happen when FPI is enabled.

Gary, I just wanted to check whether you intend to uplift FPI bug 1330467 to ESR 68 for desktop Firefox or Tor. Fennec has no need for FPI bug 1330467 in ESR 68, but if you do uplift it for desktop Firefox or Tor, then we will need to also uplift this Fennec fix.

Comment 11

[Gary Chen [:xeonchen]]

(In reply to Chris Peterson [:cpeterson] from comment #10)

(In reply to Gary Chen [:xeonchen] from comment #9)

(In reply to Chris Peterson [:cpeterson] from comment #7)

Tom or Arthur, will privacy.firstparty.isolate bug 1330467 be uplifted to Firefox ESR 68 (for Tor)? Tom mentioned ESR in bug 1330467 comment 51.
...
I'm okay to uplift bug 1330467 since regressions caused by it only happen when FPI is enabled.

Gary, I just wanted to check whether you intend to uplift FPI bug 1330467 to ESR 68 for desktop Firefox or Tor. Fennec has no need for FPI bug 1330467 in ESR 68, but if you do uplift it for desktop Firefox or Tor, then we will need to also uplift this Fennec fix.

Sorry I misunderstood. No, I personally don't feel like to uplift this feature since there are still some regressions unresolved.