Closed Bug 1568540 Opened 2 years ago Closed 2 years ago

Update the url crate to 2.0 in the webdriver crate

Categories

(Testing :: geckodriver, task, P2)

Version 3
task

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: SimonSapin, Assigned: SimonSapin)

References

Details

Attachments

(3 files, 2 obsolete files)

This will help avoid having two versions of url in Servo. To also avoid having two versions in mozilla-central, it also needs updating other crates:

We depend on tungstenite through tokio, so thanks for opening a PR there.
There doesn’t appear to be any API changes in url that affects webdriver moving from version 1 to 2.

Status: NEW → ASSIGNED
Priority: -- → P1

I was planning to submit patches after all the other PRs have landed and are on crates.io, to avoid having a large revendor patch that duplicates multiple crates. But if you prefer landing this now, that works too.

We can hold off. It’s just running ./mach vendor rust again.

Attachment #9080362 - Attachment is obsolete: true
Attachment #9080363 - Attachment is obsolete: true
Priority: P1 → P2
No longer blocks: 1520585

[import_pr] From https://github.com/servo/webrender/pull/3720

MozReview-Commit-ID: AsI4hT0cFGJ

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Blocks: 1520585
No longer blocks: 1573798
You need to log in before you can comment on or make changes to this bug.