Closed Bug 1568735 Opened 6 years ago Closed 5 months ago

AttributeError: 'MarionetteProtocol' object has no attribute 'generate_test_report'

Categories

(Testing :: web-platform-tests, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1909662

People

(Reporter: whimboo, Unassigned)

References

(Blocks 1 open bug)

Details

Currently I can see this output in a lot of web-platform tests log files. Not sure what the implications are given that the jobs are finishing with success. Here the details:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258240355&repo=mozilla-central&lineNumber=1653

[task 2019-07-25T05:14:52.881Z] 05:14:52 WARNING - Action generate_test_report failed
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - Traceback (most recent call last):
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/base.py", line 618, in process_action
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - action_handler(payload)
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/base.py", line 687, in call
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - self.protocol.generate_test_report.generate_test_report(message)
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - AttributeError: 'MarionetteProtocol' object has no attribute 'generate_test_report'
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING -
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - Traceback (most recent call last):
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py", line 624, in _run
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - self.result = True, self.func(self.protocol, self.url, self.timeout)
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/executormarionette.py", line 742, in do_testharness
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - done, rv = handler(result)
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/base.py", line 604, in call
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - return callback(url, payload)
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/base.py", line 618, in process_action
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - action_handler(payload)
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - File "/builds/worker/workspace/build/tests/web-platform/tests/tools/wptrunner/wptrunner/executors/base.py", line 687, in call
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - self.protocol.generate_test_report.generate_test_report(message)
[task 2019-07-25T05:14:52.883Z] 05:14:52 WARNING - AttributeError: 'MarionetteProtocol' object has no attribute 'generate_test_report'

The priority flag is not set for this bug.
:jgraham, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(james)

This is a feature we don't implement that has a WebDriver API. So we get a warning because the testdriver feature isn't implemented. The right thing to do here is to ensure that we just finish the test with an error status and a useful message.

Flags: needinfo?(james)
Priority: -- → P3

We are about to enable part of the Reporting API and would be great to have this webDriver method.
Can we have somebody working on this bug?

Flags: needinfo?(james)

I can help out with wiring this up to marionette, and doing the testdriver parts for Firefox. But you need to tell me how to get the actual data to retun given the input parameters (presumably 1631237 is adding this API).

Flags: needinfo?(james)
Blocks: 1678012

:baku what's the status here? Do we have some of the reporting API implemented now? I'm trying to figure out what we need to do to make sure we get wpt coverage for these APIs that have additional WebDriver endpoints. Is this work blocked on something specific?

Flags: needinfo?(amarchesini)
Severity: normal → S3

We do have Reporting API, partially implemented. But this NI is 4 years old, probably you have found a solution in the meantime.

Flags: needinfo?(amarchesini)
Status: NEW → RESOLVED
Closed: 5 months ago
Duplicate of bug: 1909662
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.