1568746 - Trim expressions before displaying them in Console messages

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Florens Verschelde :fvsch]

Attachment: console-input-with-whitespace.png

Expressions like \n\n\nfoo\n\n\n are displayed in messages with all the line breaks intact, which creates big gaps in the console output.

This can be an issue with the new Editor mode, which makes it easier and more likely for users to have one or several start or end line breaks.

We should probably trim the expression before rendering it in messages.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Thanks for filing this issue Florens!
I agree we should trim before adding the message in the output

Comment 2

[Florens Verschelde :fvsch]

Attachment: Bug 1568746 - Trim input text in Console messages; r=nchevobbe

Comment 3

[Florens Verschelde :fvsch]

Tried a quick patch. I trims whitespace at the start and end, but also:

• removes trailing whitespace for each line
• keeps only 1 blank line

This is not quite Prettier, but the result seems nice.

Maybe the trailing whitespace and/or maxlines part are too opinionated. What do you think?

Comment 4

[:Harald Kirschner :digitarald]

:fvsch, this looks good and seems lax enough to work make bad cases render in a space-saving way.

Comment 5

[Florens Verschelde :fvsch]

Attachment: Bug 1568746 - Trim expressions before displaying them in Console messages; r=nchevobbe

Depends on D39316

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46b354546ad8
Trim input text in Console messages; r=nchevobbe

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/46b354546ad8