1568753 - nsIEditor.mask() can throw NS_ERROR_ILLEGAL_VALUE on empty fields when autoMaskingEnabled=false

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Matthew N. [:MattN]]

I may have found a bug with the new password masking APIs but I'm not sure if an empty field is supposed to behave in a special way:
STR:

1. Have an empty type=password field
2. field.editor.autoMaskingEnabled => true
3. field.editor.unmask(0)
4. field.editor.autoMaskingEnabled => false
5. field.editor.mask()

Expected result:

• Field should be masked again for future input
• field.editor.autoMaskingEnabled should be true

Actual result:

• Field is masked for future input
• NS_ERROR_ILLEGAL_VALUE thrown from nsIEditor.mask
• field.editor.autoMaskingEnabled is true (changed from false to true despite the error)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(away: 6/25-6/28)]

Attachment: Bug 1568753 - Make `TextEditor::SetUnmaskRangeInternal()` return NS_OK if there is no text node and `aStart` is `UINT32_MAX`

aStart of TextEditor::SetUnmaskRangeInternal() may be UINT32_MAX if
it's called for stopping unmasking. However, it returns NS_ERROR_INVALID_ARG
if there is no text node and aStart is not 0, but this is unexpected behavior.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a54fcf822e11
Make `TextEditor::SetUnmaskRangeInternal()` return NS_OK if there is no text node and `aStart` is `UINT32_MAX` r=m_kato

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a54fcf822e11