Closed Bug 1568883 Opened 4 months ago Closed 2 months ago

Stop implementing JS-exposed QueryInterface on Element

Categories

(Core :: DOM: Bindings (WebIDL), task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox70 --- wontfix
firefox71 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is going to require various work, including ditching the remaining XBL implements="" bits, I suspect.

Depends on: 1568884
Depends on: 1514926
Depends on: 1534455

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e75504ef939ad230e452fd95edb0d120e6bb5c3 has a try push for this, which crashes if someone QIs an element from JS. There's a bunch of orange. Some of that is due to the XBL "QI the JS object" bits involved in XBL implements="", hence the dependencies. Once XBL implements="" no longer exists, we should re-measure.

Priority: -- → P3

The XBL test is being removed because it was the only remaining consumer of
xbl's implements="interfacename" in the tree, and was triggering QI on elements
for that codepath.

I've verified that a try run that MOZ_CRASHes when the C++ binding
QueryInterface implementation is invoked is green with these changes.

Assignee: nobody → bzbarsky
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3f5f69f38a8
Remove the QI implementation from Web IDL elements.  r=peterv,mossop
Backout by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6828efea7943
Backed out 2 changesets (bug 1568883, bug 1568249) for causing c1 failures in dom/base/test/chrome/test_cpows.xul CLOSED TREE

Hmph, I thought I had tested the CPOW stuff locally... It needs a bit more work, clearly. :(

Depends on: 1588231
Flags: needinfo?(bzbarsky)
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02578c5bb203
Remove the QI implementation from Web IDL elements.  r=peterv,mossop
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Keywords: dev-doc-needed

Looks like an internals thing to me — no MDN change needed?

Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.