1568883 - Stop implementing JS-exposed QueryInterface on Element

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task, P3)

Description

[Boris Zbarsky [:bzbarsky]]

This is going to require various work, including ditching the remaining XBL implements="" bits, I suspect.

Comment 1

[Boris Zbarsky [:bzbarsky]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e75504ef939ad230e452fd95edb0d120e6bb5c3 has a try push for this, which crashes if someone QIs an element from JS. There's a bunch of orange. Some of that is due to the XBL "QI the JS object" bits involved in XBL implements="", hence the dependencies. Once XBL implements="" no longer exists, we should re-measure.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1568883. Remove the QI implementation from Web IDL elements. r=peterv,mossop

The XBL test is being removed because it was the only remaining consumer of
xbl's implements="interfacename" in the tree, and was triggering QI on elements
for that codepath.

I've verified that a try run that MOZ_CRASHes when the C++ binding
QueryInterface implementation is invoked is green with these changes.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3f5f69f38a8
Remove the QI implementation from Web IDL elements.  r=peterv,mossop

Comment 4

[Stefan Hindli [:stefan_hindli]]

Backed out 2 changesets (Bug 1568883, Bug 1568249) for causing c1 failures in dom/base/test/chrome/test_cpows.xul CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=e2e7da01948565b12063332b46a9dbe266f0b0d0&selectedJob=270941083

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270941083&repo=autoland&lineNumber=60080

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6828efea7943
Backed out 2 changesets (bug 1568883, bug 1568249) for causing c1 failures in dom/base/test/chrome/test_cpows.xul CLOSED TREE

Comment 6

[Boris Zbarsky [:bzbarsky]]

Hmph, I thought I had tested the CPOW stuff locally... It needs a bit more work, clearly. :(

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02578c5bb203
Remove the QI implementation from Web IDL elements.  r=peterv,mossop

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/02578c5bb203

Comment 9

[Chris Mills [:cmills]]

Looks like an internals thing to me — no MDN change needed?