1568894 - Add PaintThread to profiler Settings panel

Status: NEW

(Core :: Gecko Profiler, enhancement, P3)

Description

[Andrew Swan [:aswan]]

The "Threads" section of the profiler settings offers a list of well-known gecko threads that includes "PaintWorker". That name is used at least on mac, but on windows painting happens on "PaintThread". It would be nice to have that in the UI on Windows. Right now, if you try to profile PaintWorker on windows it is effectively a no-op which leads to a confusing experience.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Please note that you can manually add "PaintThread" in the custom list just below the thread checkboxes.
But agreed, it would be nice to add such common threads.

In case you/someone wants to do this before the PerfTools team can get to it: See https://searchfox.org/mozilla-central/search?q=ImgDecoder&case=false&regexp=false&path= for how the "ImgDecoder" option is handled, we'll want the same for "PaintThread".

(We have bug 1321607 to eventually automate gathering this list of threads.)

Comment 2

[Julien Wajsberg [:julienw]]

As a quick note, I think this should happen both in the popup, and in the devtools' panel. We actually see both locations in the search linked in comment 1.

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Also, probably we should care about the addon too, since some people still don't know about the new integrated popup.

Comment 4

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

PaintThread was removed in bug 1726672