Closed Bug 1569004 Opened 4 months ago Closed 4 months ago

Convert Varcache prefs in TimeoutManager to StaticPrefs

Categories

(Core :: Preferences: Backend, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: KrisWright, Assigned: KrisWright)

References

(Blocks 1 open bug)

Details

Attachments

(12 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

The 13 VarCache prefs in TimeoutManager.cpp could all be converted to StaticPrefs and added to StaticPrefList.yaml. These prefs are found in TimeoutManager::Initialize(), here: https://searchfox.org/mozilla-central/source/dom/base/TimeoutManager.cpp#481

Converts dom.min_timeout_value varcache pref from TimeoutManager::Initialize() to a static pref, and removes its entry and associated constants from TimeoutManager.cpp and all.js

Assignee: nobody → kwright
Component: General → Preferences: Backend

Converts dom.disable_open_click_delay from a VarCache pref in TimeoutManager.cpp to StaticPref, removes all.js entry, and corrects a typo where the value was mentioned in nsGlobalWindowInner.cpp.

Converts dom.timeout.max_consecutive_callbacks_ms varcache pref in TimeoutManager.cpp to static pref, removes associated variables and all.js entry, and adds entry to StaticPrefList.yaml.

Converts dom.timeout.throttling_delay in TimeoutManager.cpp from varcache pref to static pref, removes entry in all.js, and adds entry in StaticPrefList.yaml. Favors the all.js value over the declared value in TimeoutManager.cpp.

Removes dom.min_tracking_timeout_value and dom.min_tracking_background_timeout_value, because they are never used.

Converts dom.min_background_timeout_value in TimeoutManager.cpp to static pref, removes entry in all.js, adds entry to StaticPrefList.yaml.

Converts dom.timeout.background_budget_regeneration_rate varcache pref in TimeoutManager.cpp to static pref, removes entry in all.js, adds entry to StaticPrefList.yaml.

Converts dom.timeout.foreground_budget_regeneration_rate varcache pref in TimeoutManager.cpp to static pref, removes entry in all.js, adds entry in StaticPrefList.yaml.

Converts dom.timeout.background_throttling_max_budget varcache pref to static pref, removes all.js entry, adds entry to StaticPrefList.yaml.

Converts dom.timeout.foreground_throttling_max_budget to static pref, removes all.js entry, updates usage, adds entry to StaticPrefList.yaml.

Converts dom.timeout.budget_throttling_max_delay varcache pref to static pref, removes entry from all.js, and adds entry to StaticPrefList.yaml

Converts dom.timeout.enable_budget_timer_throttling from varcache pref to static pref, removes entry from all.js, adds entry to StaticPrefList.yaml. Uses the all.js value and not the value declared in TimeoutManager.cpp. Since this removes the last varcache pref from TimeoutManager::Initialize(), I also removed the Initialize() function and its call in nsGlobalWindowInner.

All done! Nice work. I recommend doing a try push once you've done your fix-ups. I often use this invocation:

    ./mach try fuzzy -q "^build" -q "^test-linux64/" -q "^test-linux64-asan/"

defined with the alias try-build-all-test-linux64-some. It builds on all platforms and runs all tests on some of the Linux64 platforms.

Pushed by kwright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2655857e489d
Convert dom.min_timeout_value to StaticPref r=njn
https://hg.mozilla.org/integration/autoland/rev/a5d0fdf98930
Convert dom.min_background_timeout_value to StaticPref. r=njn
https://hg.mozilla.org/integration/autoland/rev/9f8ada36cf9b
Remove dom.min_tracking_timeout_value and dom.min_tracking_background_timeout_value varcache prefs. r=njn
https://hg.mozilla.org/integration/autoland/rev/5986fb6ed82f
Convert dom.timeout.throttling_delay to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/a8d9b6cde064
Convert dom.timeout.max_consecutive_callbacks_ms to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/0708d16f56de
convert dom.disable_open_click_delay to StaticPref. r=njn
https://hg.mozilla.org/integration/autoland/rev/68cb4f3a31fd
Convert dom.timeout.background_budget_regeneration_rate to StaticPref. r=njn
https://hg.mozilla.org/integration/autoland/rev/89aacbb2f52f
Convert dom.timeout.foreground_budget_regeneration_rate to StaticPref. r=njn
https://hg.mozilla.org/integration/autoland/rev/3d7f9cba78a7
Convert dom.timeout.background_throttling_max_budget to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/ba7879d87773
Convert dom.timeout.foreground_throttling_max_budget to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/760fd1f56980
Convert dom.timeout.budget_throttling_max_delay to static pref. r=njn
https://hg.mozilla.org/integration/autoland/rev/0a9a0b8b35fa
Convert dom.timeout.enable_budget_timer_throttling to static pref. r=njn
You need to log in before you can comment on or make changes to this bug.