Move JSScript::Flags to BaseScript
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
Details
Attachments
(3 files)
Now that there is a js::BaseScript, we can centralize the flags for LazyScript and JSScript are start de-duplicating accessors. First move the flag definitions and fields, and then move accessors in other patches.
Assignee | ||
Comment 1•5 years ago
|
||
These flags are already shared by LazyScript and JSScript. Later patches
will move the fields and accessors.
Assignee | ||
Comment 2•5 years ago
|
||
This moves the actual fields to the base scripts and unifies the basic
hasFlag / setFlag operations.
Depends on D39441
Assignee | ||
Updated•5 years ago
|
Comment 4•5 years ago
|
||
bugherder |
Comment 5•5 years ago
|
||
Refactor accessors for flags into BaseScript from JSSript and LazyScript, following earlier
change by tcampbell@ in a17d8450 to move flag enum definitions to common base.
Comment 6•5 years ago
|
||
Refactoring patch above completes this change.
Try run on treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d6801d7794afcb018572ef5e4ae3f493b20ac8b
Assignee | ||
Comment 7•5 years ago
|
||
Clearing this until we fix that patch name. One of me of Kannan can do the landing..
Updated•5 years ago
|
Updated•5 years ago
|
Comment 9•5 years ago
|
||
bugherder |
Description
•