Closed Bug 1569063 Opened 4 months ago Closed 3 months ago

Move JSScript::Flags to BaseScript

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Now that there is a js::BaseScript, we can centralize the flags for LazyScript and JSScript are start de-duplicating accessors. First move the flag definitions and fields, and then move accessors in other patches.

These flags are already shared by LazyScript and JSScript. Later patches
will move the fields and accessors.

This moves the actual fields to the base scripts and unifies the basic
hasFlag / setFlag operations.

Depends on D39441

Keywords: leave-open
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a17d8450a0f9
Move JSScript::ImmutableFlags/MutableFlags to js::BaseScript. r=jandem
https://hg.mozilla.org/integration/autoland/rev/fedbb2610bf2
Move flag fields to js::BaseScript. r=jandem

Refactor accessors for flags into BaseScript from JSSript and LazyScript, following earlier
change by tcampbell@ in a17d8450 to move flag enum definitions to common base.

Refactoring patch above completes this change.

Try run on treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d6801d7794afcb018572ef5e4ae3f493b20ac8b

Clearing this until we fix that patch name. One of me of Kannan can do the landing..

Keywords: checkin-needed
Attachment #9085245 - Attachment description: Bug 1569063 - Move JSScript::ImmutableFlags/MutableFlags to js::BaseScript. r=djvj → Bug 1569063 - Refactor accessors for flags into BaseScript from JSScript and LazyScript
Attachment #9085245 - Attachment description: Bug 1569063 - Refactor accessors for flags into BaseScript from JSScript and LazyScript → Bug 1569063 - Refactor accessors for flags into BaseScript from JSScript and LazyScript. r=tcampbell
Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f48c581ece1b
Refactor accessors for flags into BaseScript from JSScript and LazyScript. r=djvj,tcampbell
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.