1569063 - Move JSScript::Flags to BaseScript

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Ted Campbell [:tcampbell]]

Now that there is a js::BaseScript, we can centralize the flags for LazyScript and JSScript are start de-duplicating accessors. First move the flag definitions and fields, and then move accessors in other patches.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1569063 - Move JSScript::ImmutableFlags/MutableFlags to js::BaseScript. r?jandem

These flags are already shared by LazyScript and JSScript. Later patches
will move the fields and accessors.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1569063 - Move flag fields to js::BaseScript. r?jandem

This moves the actual fields to the base scripts and unifies the basic
hasFlag / setFlag operations.

Depends on D39441

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a17d8450a0f9
Move JSScript::ImmutableFlags/MutableFlags to js::BaseScript. r=jandem
https://hg.mozilla.org/integration/autoland/rev/fedbb2610bf2
Move flag fields to js::BaseScript. r=jandem

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a17d8450a0f9
https://hg.mozilla.org/mozilla-central/rev/fedbb2610bf2

Comment 5

[Chris Fallin [:cfallin]]

Attachment: Bug 1569063 - Refactor accessors for flags into BaseScript from JSScript and LazyScript. r=tcampbell

Refactor accessors for flags into BaseScript from JSSript and LazyScript, following earlier
change by tcampbell@ in a17d8450 to move flag enum definitions to common base.

Comment 6

[Chris Fallin [:cfallin]]

Refactoring patch above completes this change.

Try run on treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d6801d7794afcb018572ef5e4ae3f493b20ac8b

Comment 7

[Ted Campbell [:tcampbell]]

Clearing this until we fix that patch name. One of me of Kannan can do the landing..

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f48c581ece1b
Refactor accessors for flags into BaseScript from JSScript and LazyScript. r=djvj,tcampbell

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f48c581ece1b