1569078 - Textarea won't resize properly in translate.google.com

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P1)

Description

[atlanto]

STR:

1. Open https://translate.google.com
2. Enter some long sentence in textarea

ER:
The sentence is displayed fully.

AR:
The sentence is displayed partially. First 3 lines only.

mozregression Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fc14e15221007541122d68dadb6e47d083a8463f&tochange=97e691afc504c62ba2295bb3e9c3d33204b15d60

Regressed by bug 1456052.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Thanks for finding this, I'll take a look.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Testcase.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

[Tracking Requested - why for this release]: Don't want to let this fall onto the cracks.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Overflow area test-case (requires layout.css.overflow-clip-box.enabled=true).

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1569078 - Make overflow-clip-box: padding-box not affect the scrollable overflow region when mixed with content-box. r=mats!

This is observable via CSSOM APIs, and websites rely on them being inflatted by
the padding-box in the it to make textareas auto-sizable...

I think this is wrong though, since if I make overflow-clip-box a paint-only
thing, then the overflow areas match the ones that we get before this patch.

Which means I'd need a textarea-specific patch that does the inflation...

This doesn't make any reftest fail either, and would need a test if we go for
this, probably in the lines of the test-case attached to the bug... I'll comment
with alternatives on the bug.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

So this patch changes behavior in a way that's partially undesired, in the sense that it makes scrollHeight differ between overflow-clip-box: padding-box and overflow-clip-box: padding-box content-box. See the test-case attached for an example.

So here are the options as I see them:

• Taking the attached patch (plus a test). I think it's a bit unfortunate, but it may be fine to say that we always get the content-box scrollable area if any of the directions specifies content-box? A bit awkward.

• Add a textarea-specific code-path that takes this path. Even more awkward.

• Taking this patch and changing behavior for all elements too (that is, probably "fixing" bug 748518 / bug 1527949) in a follow-up (maybe fine?).

• Not taking this patch and asking Google to fix it? Though it seems plausible that other sites are affected.

• Reverting the regressing bug. The regressing bug was not a huge priority to get fixed, and it seems we could live without fixing it, at least for now...

Mats, any thoughts?

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Err, see comment above. +dholbert too :)

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Emilio, any news on this work? Thanks

Comment 9

[Emilio Cobos Álvarez (:emilio)]

I'm waiting from feedback from mats@ / dholbert@ (see comment 7).

We can back out the regressing bug as needed, I suspect.

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #9)

I'm waiting from feedback from mats@ / dholbert@ (see comment 7).

We can back out the regressing bug as needed, I suspect.

If we can't fix that bug before the beta merge, that's a likely option yes :)

Comment 11

[Daniel Holbert [:dholbert]]

Sorry, I'd forgotten about the pending needinfo.

I tend to think we should backout the regressing bug until we've got a more complete solution that we feel good about (perhaps involving bug 1527949?).

Comment 12

[Mats Palmgren (inactive)]

I agree that backing out bug 1456052 seems like the best short-term fix.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff602e12fd45
Back out changeset 97e691afc504c62ba2295bb3e9c3d33204b15d60 (bug 1456052) for causing this bug.

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ff602e12fd45

Comment 15

[Alexandru Trif, Desktop QA [:atrif]]

Hello!
Reproduced the issue with Firefox 70.0a1 (20190725215157) on Windows 10x64.
The issue is verified fixed with 70.0b7 (20190916074538) on Windows 10x64 following STR from comment 0.