[jsdbg2] js/src/debugger #includes are utterly meaningless
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: jimb, Assigned: jimb)
References
(Blocks 1 open bug)
Details
(Whiteboard: [debugger-mvp])
Attachments
(1 file)
After rearranging the code in js/src/debugger, I have no idea which headers are actually necessary, nor whether we're #including everything we ought to. (Thanks, C++!) Especially with so much stuff getting moved out of Debugger.cpp, it would be nice to bring the headers up to date.
There is a clang-based tool out there, Include What You Use, that does this. It would be nice to consult it for advice on the new files in js/src/debugger.
|
Assignee | |
Comment 1•5 years ago
|
||
These changes were produced using the Include What You Use tool, which uses the
Clang front end to figure out which headers actually declare the identifiers
you're using.
These changes aren't exactly the ones IWYU suggests. The tool has some odd false
positives, even when you use its 'pragmas' to tell it about headers like
jsapi.h, which is supposed to gather up other headers for you. And there are
some cases where I could get away with a forward declaration (say, for Maybe),
but I really just want to #include the full header because it seems better. But
overall this patch has only minor deviations from IWYU's suggestions.
No intended change in execution or visible behavior.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
Pushed by jblandy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e202a998734c Correct #includes in js/src/debugger. r=jorendorff
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Description
•