1569100 - Add support for more WebDriver Command and Parameter types in Marionette crate

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement, P2)

Description

[Nupur Baghel]

Bug 1565210 introduced the use of WebDriver:FindElement and WebDriver:GetTimeouts (from Marionette crate) in geckodriver. We now need to add support for other WebDriver Command and Parameter types in Marionette crate. And further use each of these in geckodriver.

Comment 1

[Nupur Baghel]

Attachment: Bug 1569100 - Add FindElements command and WebElements response types to Marionette. r=ato

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be310b9aa0a6
Add FindElements command and WebElements response types to Marionette. r=ato

Comment 3

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette crate: move WebElement and Timeouts objects to common module. r=ato

Both WebElement and Timeouts objects are used by the request and response stages.
Hence moving them to the common module.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45a8ea98e8fc
Marionette crate: move WebElement and Timeouts objects to common module. r=ato

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/be310b9aa0a6
https://hg.mozilla.org/mozilla-central/rev/45a8ea98e8fc

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Andreas, why does this bug need to stay open?

Comment 7

[Andreas Tolfsen ❲:ato❳]

Nupur is going to push more patches to this bug.

Comment 8

[Nupur Baghel]

Attachment: Bug 1569100 - Add SetTimeouts command to Marionette. r=ato

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/571761c0b3b9
Add SetTimeouts command to Marionette. r=ato

Comment 10

[Natalia Csoregi [:nataliaCs]]

Backed out for web platform failures on set_timeouts/set.py

backout: https://hg.mozilla.org/integration/autoland/rev/1e79f1d7355836952bdc69a994547007c18e3a93

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=web-platform-tests-wdspec-&revision=571761c0b3b93c63ce6944582d88d7184394a85d

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258791756&repo=autoland&lineNumber=89269

[task 2019-07-29T13:38:11.983Z] 13:38:11 INFO - TEST-PASS | /webdriver/tests/set_timeouts/set.py | test_value_positive_integer[9007199254740992-script]
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - TEST-PASS | /webdriver/tests/set_timeouts/set.py | test_set_all_fields
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - TEST-UNEXPECTED-FAIL | /webdriver/tests/set_timeouts/set.py | test_script_value_null - assert 30000 is None
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - session = <Session 03674300-e02a-274c-8c02-b845aa358088>
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO -
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - def test_script_value_null(session):
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - response = set_timeouts(session, {"script": None})
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - assert_success(response)
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO -
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - > assert session.timeouts.script is None
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - E assert 30000 is None
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - E + where 30000 = <webdriver.client.Timeouts object at 0x1052f12d0>.script
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - E + where <webdriver.client.Timeouts object at 0x1052f12d0> = <Session 03674300-e02a-274c-8c02-b845aa358088>.timeouts
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO -
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - response = <Responsetatus=200 body={"value": null}>
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - session = <Session 03674300-e02a-274c-8c02-b845aa358088>
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO -
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - tests/web-platform/tests/webdriver/tests/set_timeouts/set.py:95: AssertionError
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - TEST-OK | /webdriver/tests/set_timeouts/set.py | took 5719ms

Comment 11

[Nupur Baghel]

Updated the patch. Script is now successfully serialized to Null values also. This should fix the test.

Comment 12

[Nupur Baghel]

Attachment: Bug 1569100 - Add Cookie, Date types and AddCookie command to Marionette. r=ato

Comment 13

[Nupur Baghel]

Attachment: Bug 1569100 - Add GetCookies command and Cookies response types. r=ato

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4a6bfabe3c3
Add SetTimeouts command to Marionette. r=ato
https://hg.mozilla.org/integration/autoland/rev/15871237b7d5
Add Cookie, Date types and AddCookie command to Marionette. r=ato
https://hg.mozilla.org/integration/autoland/rev/afcc47871261
Add GetCookies command and Cookies response types. r=ato

Comment 15

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a4a6bfabe3c3
https://hg.mozilla.org/mozilla-central/rev/15871237b7d5
https://hg.mozilla.org/mozilla-central/rev/afcc47871261

Comment 16

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add DeleteCookie, DeleteCookies commands & Geckodriver: GetNamedCookie converted to GetCookies. r=ato

Since GetNamedCookie is currently not supported by the marionette server, the corresponding WebDriver command is converted to GetCookies command.

Comment 17

[Nupur Baghel]

Attachment: Bug 1569100 - Add NewWindow command and NewWindow response types to Marionette crate. r=ato

Depends on D39923

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e722cd1cb79
Marionette: Add DeleteCookie, DeleteCookies commands & Geckodriver: GetNamedCookie converted to GetCookies. r=ato
https://hg.mozilla.org/integration/autoland/rev/a754c63e321c
Add NewWindow command and NewWindow response types to Marionette crate. r=ato

Comment 19

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4e722cd1cb79
https://hg.mozilla.org/mozilla-central/rev/a754c63e321c

Comment 20

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add CloseWindow, FullscreenWindow, MaximiseWindow, MinimiseWindow commands and WindowRect type. r=ato

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fdbf8fca123
Marionette: Add CloseWindow, FullscreenWindow, MaximiseWindow, MinimiseWindow commands and WindowRect type. r=ato

Comment 22

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add GetWindowHandle, GetWindowHandles, GetWindowRect, SetWindowRect commands and WindowRect type for request. r=ato

Apart from adding all the new types, also fixed some marionette tests for webelements which was incorrectly deserialized.

Comment 23

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/5fdbf8fca123

Comment 24

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add AcceptAlert, DismissAlert, GetAlertText and SendAlertText commands. r=ato

Comment 25

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add ExecuteScript, ExecuteAsyncScript commands and Script type. r=ato

Comment 26

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add GetActiveElement, GetElementAttribute, GetElementProperty, GetElementRect, GetElementTagName, GetElementText, ElementClear, ElementClick, IsDisplayed, IsSelected, IsEnabled commands and Bool, ElementRect response...

...types. r=ato

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88e7f43aa21d
Marionette: Add GetWindowHandle, GetWindowHandles, GetWindowRect, SetWindowRect commands and WindowRect type for request. r=ato

Comment 28

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/88e7f43aa21d

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9334976aea6a
Marionette: Add AcceptAlert, DismissAlert, GetAlertText and SendAlertText commands. r=ato

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84fe377bc84f
Marionette: Add ExecuteScript, ExecuteAsyncScript commands and Script type. r=ato

Comment 31

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/9334976aea6a
https://hg.mozilla.org/mozilla-central/rev/84fe377bc84f

Comment 32

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Fix deserialization of value-wrapped MarionetteResult types. r=ato

Comment 33

[Andreas Tolfsen ❲:ato❳]

On applying D40816, autoland reports:

applying /tmp/tmpk6g1_6 1 out of 1 hunk ignored -- saving rejects to file testing/geckodriver/marionette/src/webdriver.rs.rej abort: patch command failed: exited with status 256 

Comment 34

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add GetElementAttribute and GetElementProperty commands. r=ato

Comment 35

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add GetActiveElement, GetElementRect, GetElementTagName and GetElementText commands. r=ato

Comment 36

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add IsDisplayed, IsEnabled and IsSelected commands and Bool response type. r=ato

Comment 37

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58a6f21cdcd8
Marionette: Fix deserialization of value-wrapped MarionetteResult types. r=ato
https://hg.mozilla.org/integration/autoland/rev/4e4a24f41d7f
Marionette: Add GetElementAttribute and GetElementProperty commands. r=ato
https://hg.mozilla.org/integration/autoland/rev/7c1fd3cac6dc
Marionette: Add GetActiveElement, GetElementRect, GetElementTagName and GetElementText commands. r=ato
https://hg.mozilla.org/integration/autoland/rev/3697bcc282df
Marionette: Add IsDisplayed, IsEnabled and IsSelected commands and Bool response type. r=ato

Comment 38

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add DeleteSession command. r=ato

Comment 39

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae70794d4b51
Marionette: Add DeleteSession command. r=ato

Comment 40

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add ElementClear, ElementClick, GoBack and GoForward commands. r=ato

Comment 41

[Nupur Baghel]

Attachment: Bug 1569100 - Marionette: Add FindElementElement and FindElementElements commands. r=ato

Comment 42

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84c3dbb41e47
Marionette: Add ElementClear, ElementClick, GoBack and GoForward commands. r=ato
https://hg.mozilla.org/integration/autoland/rev/5dc6a1b9d6c5
Marionette: Add FindElementElement and FindElementElements commands. r=ato

Comment 43

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/58a6f21cdcd8
https://hg.mozilla.org/mozilla-central/rev/4e4a24f41d7f
https://hg.mozilla.org/mozilla-central/rev/7c1fd3cac6dc
https://hg.mozilla.org/mozilla-central/rev/3697bcc282df

Comment 44

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/ae70794d4b51
https://hg.mozilla.org/mozilla-central/rev/84c3dbb41e47
https://hg.mozilla.org/mozilla-central/rev/5dc6a1b9d6c5

Comment 45

[Nupur Baghel]

Attachment: bug 1569100: marionette: add Get, GetCurrentUrl, GetPageSource, and GetTitle commands;

Comment 46

[Nupur Baghel]

Attachment: bug 1569100: marionette: add GetCSSValue command;

Depends on D41499

Comment 47

[Nupur Baghel]

Attachment: bug 1569100: marionette: add Refresh, ReleaseActions, and SwitchToParentFrame commands;

Comment 48

[Nupur Baghel]

Attachment: bug 1569100: marionette: add SwitchToFrame command;

Comment 49

[Nupur Baghel]

Attachment: bug 1569100: marionette: add SwitchToWindow command;

Depends on D41514

Comment 50

[Nupur Baghel]

Attachment: bug 1569100: marionette: add TakeElementScreenshot, TakeScreenshot, and TakeFullScreenshot commands;

Depends on D41518

Comment 51

[Nupur Baghel]

Attachment: bug 1569100: marionette: add ElementSendKeys command;

Depends on D41530

Comment 52

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4aad0d4dca1f
Marionette: Add Get(i.e. Navigate), GetCurrentUrl, GetPageSource and GetTitle commands. r=ato
https://hg.mozilla.org/integration/autoland/rev/23747eab418f
Marionette: Add GetCSSValue command. r=ato
https://hg.mozilla.org/integration/autoland/rev/294303d325ca
Marionette: Add Refresh, ReleaseActions and SwitchToParentFrame commands. r=ato
https://hg.mozilla.org/integration/autoland/rev/c7cc3d8738e6
Marionette: Add SwitchToFrame command and SwitchToFrame, Frame types. r=ato
https://hg.mozilla.org/integration/autoland/rev/af9451f15665
Marionette: Add SwitchToWindow command and SwitchToWindow type. r=ato
https://hg.mozilla.org/integration/autoland/rev/347d252902b9
Add TakeElementScreenshot, TakeScreenshot and TakeFullScreenshot commands. r=ato
https://hg.mozilla.org/integration/autoland/rev/c9853685124c
Marionette: Add ElementSendKeys command. r=ato

Comment 53

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58c2f8a1f337
Backed out 7 changesets for causing close_window/close.py, accept_alert/accept.py perma failures CLOSED TREE

Comment 54

[Andreas Tolfsen ❲:ato❳]

I will pick up the remaining work to land the seven last patches.

Comment 55

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/304046f8c84b
marionette: add Get, GetCurrentUrl, GetPageSource, and GetTitle commands; r=ato
https://hg.mozilla.org/integration/autoland/rev/63645bfd52ed
marionette: add GetCSSValue command; r=ato
https://hg.mozilla.org/integration/autoland/rev/7480ca4f3652
marionette: add Refresh, ReleaseActions, and SwitchToParentFrame commands; r=ato
https://hg.mozilla.org/integration/autoland/rev/0cd0438d6b9c
marionette: add SwitchToFrame command; r=ato
https://hg.mozilla.org/integration/autoland/rev/33e207c8bec6
marionette: add SwitchToWindow command; r=ato
https://hg.mozilla.org/integration/autoland/rev/15005baa16c4
marionette: add TakeElementScreenshot, TakeScreenshot, and TakeFullScreenshot commands; r=ato
https://hg.mozilla.org/integration/autoland/rev/f35acde957db
marionette: add ElementSendKeys command; r=ato

Comment 56

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/304046f8c84b
https://hg.mozilla.org/mozilla-central/rev/63645bfd52ed
https://hg.mozilla.org/mozilla-central/rev/7480ca4f3652
https://hg.mozilla.org/mozilla-central/rev/0cd0438d6b9c
https://hg.mozilla.org/mozilla-central/rev/33e207c8bec6
https://hg.mozilla.org/mozilla-central/rev/15005baa16c4
https://hg.mozilla.org/mozilla-central/rev/f35acde957db

Comment 57

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It's not strictly blocking the 0.26.0 release if it hasn't been finished, but adding the dependency to ensure we don't forget to update the changelog for those changes.

Comment 58

[Andreas Tolfsen ❲:ato❳]

We are done here!

I’ve filed follow-up bugs for the remaining work that I outlined here:
https://lists.mozilla.org/pipermail/tools-marionette/2019-September/000109.html

Comment 59

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Ah, right. Even better. Thanks!