Add support for more WebDriver Command and Parameter types in Marionette crate
Categories
(Testing :: geckodriver, enhancement, P2)
Tracking
(Not tracked)
People
(Reporter: nupurbaghel, Assigned: ato)
References
(Blocks 1 open bug)
Details
Attachments
(25 files, 1 obsolete file)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
bug 1569100: marionette: add TakeElementScreenshot, TakeScreenshot, and TakeFullScreenshot commands;
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Bug 1565210 introduced the use of WebDriver:FindElement and WebDriver:GetTimeouts (from Marionette crate) in geckodriver. We now need to add support for other WebDriver Command and Parameter types in Marionette crate. And further use each of these in geckodriver.
Reporter | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be310b9aa0a6 Add FindElements command and WebElements response types to Marionette. r=ato
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Comment 3•5 years ago
|
||
Both WebElement and Timeouts objects are used by the request and response stages.
Hence moving them to the common module.
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/45a8ea98e8fc Marionette crate: move WebElement and Timeouts objects to common module. r=ato
Comment 5•5 years ago
|
||
bugherder |
Assignee | ||
Comment 7•5 years ago
|
||
Nupur is going to push more patches to this bug.
Reporter | ||
Comment 8•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/571761c0b3b9 Add SetTimeouts command to Marionette. r=ato
Comment 10•5 years ago
|
||
Backed out for web platform failures on set_timeouts/set.py
backout: https://hg.mozilla.org/integration/autoland/rev/1e79f1d7355836952bdc69a994547007c18e3a93
failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258791756&repo=autoland&lineNumber=89269
[task 2019-07-29T13:38:11.983Z] 13:38:11 INFO - TEST-PASS | /webdriver/tests/set_timeouts/set.py | test_value_positive_integer[9007199254740992-script]
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - TEST-PASS | /webdriver/tests/set_timeouts/set.py | test_set_all_fields
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - TEST-UNEXPECTED-FAIL | /webdriver/tests/set_timeouts/set.py | test_script_value_null - assert 30000 is None
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - session = <Session 03674300-e02a-274c-8c02-b845aa358088>
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO -
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - def test_script_value_null(session):
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - response = set_timeouts(session, {"script": None})
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - assert_success(response)
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO -
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - > assert session.timeouts.script is None
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - E assert 30000 is None
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - E + where 30000 = <webdriver.client.Timeouts object at 0x1052f12d0>.script
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - E + where <webdriver.client.Timeouts object at 0x1052f12d0> = <Session 03674300-e02a-274c-8c02-b845aa358088>.timeouts
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO -
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - response = <Responsetatus=200 body={"value": null}>
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - session = <Session 03674300-e02a-274c-8c02-b845aa358088>
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO -
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - tests/web-platform/tests/webdriver/tests/set_timeouts/set.py:95: AssertionError
[task 2019-07-29T13:38:11.984Z] 13:38:11 INFO - TEST-OK | /webdriver/tests/set_timeouts/set.py | took 5719ms
Reporter | ||
Comment 11•5 years ago
|
||
Updated the patch. Script is now successfully serialized to Null values also. This should fix the test.
Reporter | ||
Comment 12•5 years ago
|
||
Reporter | ||
Comment 13•5 years ago
|
||
Comment 14•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a4a6bfabe3c3 Add SetTimeouts command to Marionette. r=ato https://hg.mozilla.org/integration/autoland/rev/15871237b7d5 Add Cookie, Date types and AddCookie command to Marionette. r=ato https://hg.mozilla.org/integration/autoland/rev/afcc47871261 Add GetCookies command and Cookies response types. r=ato
Comment 15•5 years ago
|
||
bugherder |
Reporter | ||
Comment 16•5 years ago
|
||
Since GetNamedCookie is currently not supported by the marionette server, the corresponding WebDriver command is converted to GetCookies command.
Reporter | ||
Comment 17•5 years ago
|
||
Depends on D39923
Comment 18•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e722cd1cb79 Marionette: Add DeleteCookie, DeleteCookies commands & Geckodriver: GetNamedCookie converted to GetCookies. r=ato https://hg.mozilla.org/integration/autoland/rev/a754c63e321c Add NewWindow command and NewWindow response types to Marionette crate. r=ato
Comment 19•5 years ago
|
||
bugherder |
Reporter | ||
Comment 20•5 years ago
|
||
Comment 21•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5fdbf8fca123 Marionette: Add CloseWindow, FullscreenWindow, MaximiseWindow, MinimiseWindow commands and WindowRect type. r=ato
Reporter | ||
Comment 22•5 years ago
|
||
Apart from adding all the new types, also fixed some marionette tests for webelements which was incorrectly deserialized.
Comment 23•5 years ago
|
||
bugherder |
Reporter | ||
Comment 24•5 years ago
|
||
Reporter | ||
Comment 25•5 years ago
|
||
Reporter | ||
Comment 26•5 years ago
|
||
...types. r=ato
Comment 27•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/88e7f43aa21d Marionette: Add GetWindowHandle, GetWindowHandles, GetWindowRect, SetWindowRect commands and WindowRect type for request. r=ato
Comment 28•5 years ago
|
||
bugherder |
Comment 29•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9334976aea6a Marionette: Add AcceptAlert, DismissAlert, GetAlertText and SendAlertText commands. r=ato
Comment 30•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84fe377bc84f Marionette: Add ExecuteScript, ExecuteAsyncScript commands and Script type. r=ato
Comment 31•5 years ago
|
||
bugherder |
Reporter | ||
Comment 32•5 years ago
|
||
Assignee | ||
Comment 33•5 years ago
|
||
Reporter | ||
Comment 34•5 years ago
|
||
Reporter | ||
Comment 35•5 years ago
|
||
Reporter | ||
Comment 36•5 years ago
|
||
Comment 37•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/58a6f21cdcd8 Marionette: Fix deserialization of value-wrapped MarionetteResult types. r=ato https://hg.mozilla.org/integration/autoland/rev/4e4a24f41d7f Marionette: Add GetElementAttribute and GetElementProperty commands. r=ato https://hg.mozilla.org/integration/autoland/rev/7c1fd3cac6dc Marionette: Add GetActiveElement, GetElementRect, GetElementTagName and GetElementText commands. r=ato https://hg.mozilla.org/integration/autoland/rev/3697bcc282df Marionette: Add IsDisplayed, IsEnabled and IsSelected commands and Bool response type. r=ato
Updated•5 years ago
|
Reporter | ||
Comment 38•5 years ago
|
||
Comment 39•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae70794d4b51 Marionette: Add DeleteSession command. r=ato
Reporter | ||
Comment 40•5 years ago
|
||
Reporter | ||
Comment 41•5 years ago
|
||
Comment 42•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84c3dbb41e47 Marionette: Add ElementClear, ElementClick, GoBack and GoForward commands. r=ato https://hg.mozilla.org/integration/autoland/rev/5dc6a1b9d6c5 Marionette: Add FindElementElement and FindElementElements commands. r=ato
Comment 43•5 years ago
|
||
bugherder |
Comment 44•5 years ago
|
||
bugherder |
Reporter | ||
Comment 45•5 years ago
|
||
Reporter | ||
Comment 46•5 years ago
|
||
Depends on D41499
Reporter | ||
Comment 47•5 years ago
|
||
Reporter | ||
Comment 48•5 years ago
|
||
Reporter | ||
Comment 49•5 years ago
|
||
Depends on D41514
Reporter | ||
Comment 50•5 years ago
|
||
Depends on D41518
Reporter | ||
Comment 51•5 years ago
|
||
Depends on D41530
Updated•5 years ago
|
Comment 52•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4aad0d4dca1f Marionette: Add Get(i.e. Navigate), GetCurrentUrl, GetPageSource and GetTitle commands. r=ato https://hg.mozilla.org/integration/autoland/rev/23747eab418f Marionette: Add GetCSSValue command. r=ato https://hg.mozilla.org/integration/autoland/rev/294303d325ca Marionette: Add Refresh, ReleaseActions and SwitchToParentFrame commands. r=ato https://hg.mozilla.org/integration/autoland/rev/c7cc3d8738e6 Marionette: Add SwitchToFrame command and SwitchToFrame, Frame types. r=ato https://hg.mozilla.org/integration/autoland/rev/af9451f15665 Marionette: Add SwitchToWindow command and SwitchToWindow type. r=ato https://hg.mozilla.org/integration/autoland/rev/347d252902b9 Add TakeElementScreenshot, TakeScreenshot and TakeFullScreenshot commands. r=ato https://hg.mozilla.org/integration/autoland/rev/c9853685124c Marionette: Add ElementSendKeys command. r=ato
Comment 53•5 years ago
|
||
Backout by aciure@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/58c2f8a1f337 Backed out 7 changesets for causing close_window/close.py, accept_alert/accept.py perma failures CLOSED TREE
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 54•5 years ago
|
||
I will pick up the remaining work to land the seven last patches.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 55•5 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/304046f8c84b marionette: add Get, GetCurrentUrl, GetPageSource, and GetTitle commands; r=ato https://hg.mozilla.org/integration/autoland/rev/63645bfd52ed marionette: add GetCSSValue command; r=ato https://hg.mozilla.org/integration/autoland/rev/7480ca4f3652 marionette: add Refresh, ReleaseActions, and SwitchToParentFrame commands; r=ato https://hg.mozilla.org/integration/autoland/rev/0cd0438d6b9c marionette: add SwitchToFrame command; r=ato https://hg.mozilla.org/integration/autoland/rev/33e207c8bec6 marionette: add SwitchToWindow command; r=ato https://hg.mozilla.org/integration/autoland/rev/15005baa16c4 marionette: add TakeElementScreenshot, TakeScreenshot, and TakeFullScreenshot commands; r=ato https://hg.mozilla.org/integration/autoland/rev/f35acde957db marionette: add ElementSendKeys command; r=ato
Comment 56•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/304046f8c84b
https://hg.mozilla.org/mozilla-central/rev/63645bfd52ed
https://hg.mozilla.org/mozilla-central/rev/7480ca4f3652
https://hg.mozilla.org/mozilla-central/rev/0cd0438d6b9c
https://hg.mozilla.org/mozilla-central/rev/33e207c8bec6
https://hg.mozilla.org/mozilla-central/rev/15005baa16c4
https://hg.mozilla.org/mozilla-central/rev/f35acde957db
Comment 57•5 years ago
|
||
It's not strictly blocking the 0.26.0 release if it hasn't been finished, but adding the dependency to ensure we don't forget to update the changelog for those changes.
Assignee | ||
Comment 58•5 years ago
|
||
We are done here!
I’ve filed follow-up bugs for the remaining work that I outlined here:
https://lists.mozilla.org/pipermail/tools-marionette/2019-September/000109.html
Comment 59•5 years ago
|
||
Ah, right. Even better. Thanks!
Description
•