1569115 - When `mach try chooser` concludes, Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method _NonClosingTextIOWrapper.__del__ of <_io.TextIOWrapper encoding='utf-16-le'>> ignored

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, defect)

Description

[Marco Zehe (:MarcoZ)]

STR:

1. Commit something and run ./mach try chooser
2. Fill out the form accordingly and hit Push.
3. Close the tab, return to your console window and wait.
   • At the end of the push, after restoring the repository, the below error message is displayed:

Exception TypeError: TypeError("'NoneType' object is not callable",) in <bound method _NonClosingTextIOWrapper.del of <_io.TextIOWrapper encoding='utf-16-le'>> ignored

Comment 1

[Marco Zehe (:MarcoZ)]

Still getting this error when using ./mach try chooser.

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1569115 - Don't throw TypeError exception when using |./mach try chooser| r?rstewart

This was an issue around "six" and "click", this thread sheds some light:
https://github.com/pallets/click/issues/564.

This issue was reproducible by having a local python 2 flask app with Flask==1.0.2, Werkzeug==0.14.1 and Click==7.0. Upon self-shutdown, the TypeError was raised.

Upgrading Click to 7.1.2 resolves this issue both in that separate "reproduce app" and here in-tree.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb70d4b574cd
Don't throw TypeError exception when using |./mach try chooser| r=rstewart

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bb70d4b574cd