Twitter is not saving to history sidebar after one visit
Categories
(Firefox :: Bookmarks & History, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: pciapa, Assigned: mak)
References
()
Details
Attachments
(2 files)
Twitter is not saving to history sidebar (Hamburger menu -> Library -> History -> View history Sidebar - Today) after first navigating
Steps to reproduce:
- Open Firefox
- navigate 'https://twitter.com/')
- open History sidebar -> Today
- twitter website is not present in list of visited websites
Firefox version: 69 0b7
Comment 1•5 years ago
|
||
I can reproduce this as well on latest nightly. I can't reproduce with other sites, and it seems to be when Twitter is first navigated to.
This makes me wonder if it could be the Twitter site doing something weird.
Marco, any ideas here?
Assignee | ||
Comment 2•5 years ago
|
||
I suspect a redirect, but I'm not sure why the target is not there. it should be debugged in history.cpp
Assignee | ||
Comment 3•5 years ago
|
||
I'm looking into it, hopefully I can find the problem.
Assignee | ||
Comment 4•5 years ago
|
||
Apparently the first visit is a redirect, and the second visit gets the same identical url passed-in as lastVisitedURI, so history thinks it's a reload and skips it. I'm not sure why the docshell is telling us the page redirects to itself, so next investigation is in the docshell.
Assignee | ||
Comment 5•5 years ago
|
||
In the end the problem is that history flood protection is too aggressive in this case, we should always try to have an unhidden visit, even if the same uri is visited repeatedly.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
The history anti-flooding system prevents repeated loads of the same url from
flooding history, generating bogus frecency values.
In some cases though, like a page redirecting to itself, it may be overzealous.
A redirect source is always marked as hidden, and if the page redirects to
itself the second visit will be skipped, because repeated.
We always want to haveat least one unhidden visit in that case, thus we can
skip the anti-flooding check if the page will be unhidden.
Pushed by mak77@bonardo.net: https://hg.mozilla.org/integration/autoland/rev/1d01a8a08ebf a page redirecting to itself should appear in history. r=Standard8
Comment 8•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 9•5 years ago
|
||
Following the STR from the first comment and I couldn't reproduce the bug. Could you verify if the issue is fixed using this build: https://archive.mozilla.org/pub/firefox/candidates/70.0b7-candidates/build1/ ?
Thank you!
Reporter | ||
Comment 10•5 years ago
|
||
(In reply to Negritas Sergiu from comment #9)
Following the STR from the first comment and I couldn't reproduce the bug. Could you verify if the issue is fixed using this build: https://archive.mozilla.org/pub/firefox/candidates/70.0b7-candidates/build1/ ?
Thank you!
Sorry, I can't, this is out of scope of my responsibilities.
Description
•