Closed Bug 1569197 Opened 1 year ago Closed 1 year ago

[BinAST] Deactivate Brotli decompression

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: Yoric, Assigned: Yoric)

References

Details

Attachments

(2 files)

In the first release of context-0.x, we'll let Necko handle brotli decompression, so we need to make sure that we don't use our brotli decompression code just yet.

Priority: -- → P2

The latest version of content-0.1 does NOT embed brotli content. Rather, the protocol expects the data to be brotli-(de)compressed at the http layer, with the VM only taking care of Huffman-level compression.

This patch removes the code that we had installed to handle brotli decompression. Templatized methods that take as type argument Compress::{Yes, No} remain templatized, as we expect that we're going to need Huffman decompression
soon, but for the time being, only the uncompressed implementation remains.

Since we do not use Brotli as part of SpiderMonkey anymore, let's avoid linking it.

Pushed by dteller@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2fa438ebdc7
Backed out changeset 2a053de2828f;r=arai
Assignee: nobody → dteller
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce6819edd27e
Stop decompressing content-0.1 data's brotli layer manually. r=arai
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.