1569258 - Stopping composition recorder will crash if it hasn't already started

Status: VERIFIED FIXED

(Core :: Performance, defect)

Description

[Barret Rennie [:barret] (they/them)]

STR:

1. Open the browser console
2. windowUtils.setCompositionRecording(false)

ER:
An error / warning should be displayed

AR:
A crash.

Comment 1

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1569258 - Ensure we have a CompositionRecorder before attempting to write frames r?kvark

Instead of blindly attempting to write frames to disk, we now ensure that the
CompositionRecorder exists. In the case where we have not allocated one,
calling windowUtils.setCompositionRecording(false) will instead print an
error message to the browser console.

In addition, attempting to call windowUtils.setCompositionRecording(true)
while a CompositionRecorder exists will also result in an error message.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be7ab9301044
Ensure we have a CompositionRecorder before attempting to write frames r=kvark,mstange

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/be7ab9301044

Comment 4

[Negritas Sergiu, Desktop QA]

Following the STR from the first comment, I managed to reproduce the issue on nightly 70.0a1 (2019-07-22).
I can confirm that the issue is fixed in 70.0b6.