Closed Bug 1569263 Opened 5 months ago Closed 5 months ago

Remove/revert .ini files for now-passing `object-fit` WPT tests

Categories

(Core :: Layout, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(2 files)

Per bug 1528225 comment 18, it actually appears that some of these "dummy" .ini files actually used to contain fuzzy annotations for known intermittent failures. (At least, the one for that bug did.)

In those cases, we should restore the fuzzy annotation rather than deleting the file entirely. I'll add a "part 1" patch here that does that, and then morph the existing patch into a somewhat smaller "part 2" patch which deletes the remaining files.

Attachment #9081023 - Attachment description: Bug 1569263: remove useless object-fit WPT .ini files that only have a 'bug' field and no functional annotations. r?boris → Bug 1569263 part 1: Remove useless object-fit WPT .ini files that only have a 'bug' field and no functional annotations. r?boris

This patch was generated automatically, by running the following command:
hg revert object-fit-contain-png-001e.html.ini -r 7018488ca120836111db492baf8fc852d0b699e3
...using the revision from just before the fuzzy annotation was replaced with a temporary expected-fail annotation in bug 1559276.

Depends on D39554

(In reply to Daniel Holbert [:dholbert] from comment #2)

In those cases, we should restore the fuzzy annotation rather than deleting the file entirely. I'll add a [...]

Ah, per IRC/phabricator, it sounds like object-fit-contain-png-001e.html is the only file in this special fuzzy category, for now, so I just removed it from the main patch here and restored its fuzzy annotation in a new "part 2".

Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f69e3ed2cbb2
part 1: Remove useless object-fit WPT .ini files that only have a 'bug' field and no functional annotations. r=boris
https://hg.mozilla.org/integration/autoland/rev/9c5cdc49e2c1
part 2: Restore fuzzy annotation for web-platform-test object-fit-contain-png-001e.html now that it (usually) passes again. r=boris
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Summary: Remove useless .ini files for now-passing `object-fit` WPT tests → Remove/revert .ini files for now-passing `object-fit` WPT tests
You need to log in before you can comment on or make changes to this bug.