1569366 - Move the top sites API from toolkit to browser

Status: RESOLVED FIXED

(WebExtensions :: General, task, P1)

Description

[Drew Willcoxon :adw]

Bug 1547669 added some things to the top sites API, but it turned out to be not quite what we (the quantumbar team) needed (see bug 1568617). What we need is the list of top sites exactly as it appears on newtab. That list is determined by activity stream, which lives in browser. But the top sites API lives in toolkit.

There was an earlier, now abandoned revision for that bug [1] where it was suggested that top sites be moved to browser. So we should do that, as Shane and I discussed today.

[1] https://phabricator.services.mozilla.com/D36200

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1569366 - Move the top sites API from toolkit to browser

Bug 1547669 added some things to the top sites API, but it turned out to be not quite what we (the quantumbar team) needed (see bug 1568617). What we need is the list of top sites exactly as it appears on newtab. That list is determined by activity stream, which lives in browser. But the top sites API lives in toolkit.

There was an earlier, now abandoned revision for that bug [1] where it was suggested that top sites be moved to browser. So we should do that.

[1] https://phabricator.services.mozilla.com/D36200

Comment 2

[Drew Willcoxon :adw]

Green try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c031fd8dd8962abe6d9944c4432c54582e561cbb

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b71ffa34a339
Move the top sites API from toolkit to browser r=mixedpuppy

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b71ffa34a339

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 9081075 [details]
Bug 1569366 - Move the top sites API from toolkit to browser

Beta/Release Uplift Approval Request

• User impact if declined: This bug supports the top-sites experiment that the quantumbar/search team would like to conduct on 69.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a large-ish patch, but it only moves some code from toolkit to browser. It's an internal change, and it has no impact on product or webextension interfaces.
• String changes made/needed: None

Comment 6

[Drew Willcoxon :adw]

Marking in-testsuite- only because this specific patch doesn't have or need tests, but the top sites API does have existing tests that cover this code.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9081075 [details]
Bug 1569366 - Move the top sites API from toolkit to browser

Moves top sites API code from toolkit to browser in support of experiments targeting 69. No functional changes expected from this change and the feature has automated test coverage. Approved for 69.0b10.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9d64723b543f