Open Bug 1569427 Opened 6 years ago Updated 3 years ago

Some features don't appear until an in-place upgrade

Categories

(Toolkit :: Add-ons Manager, defect, P3)

Product:
Toolkit
Component:
Add-ons Manager
Version:
67 Branch
Type:
defect

Tracking

()

Status:
UNCONFIRMED

People

(Reporter: mschmitt, Unassigned)

Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/11.1.2 Safari/605.1.15

Steps to reproduce:

  1. I was running Firefox ESR 52.9 on macOS 10.13.6 High Sierra.
  2. Upgraded to Firefox Quantum 67.0.4 by replacing Firefox.app with the new version.
  3. Observed that certain features of Firefox releases > 52 were missing.
  4. Performed an in-place upgrade to 68.0.1 via Firefox > About Firefox.

Actual results:

After the upgrade from ESR 52 to Quantum 67, two features were missing:

  • Preferences > Privacy & Security > Forms and Autofill > Autofill addresses
  • Page actions > Take a Screenshot

By "missing" I mean the feature did not exist at all: there was no Forms and Autofill section in the preferences, and there was no Take a Screenshot action on the menu.

After the in-place upgrade to version 68 the missing features appeared.

Note: I did look for reports of which about:config settings control or suppress these features, and checked my profile. All settings were such that the features should have appeared.

Expected results:

All of the features of Firefox 67 should have appeared when doing the upgrade from ESR 29 to Quantum 67.

Note: My theory is that the features are enabled by something that only the in-place upgrade, or perhaps a completely new install, does. So it wasn't until that upgrade was performed that the features because visible.

Component: Untriaged → Preferences

This is likely a bug in the UI migration code when switching from ESR to release. Moving this out of Preferences.

Component: Preferences → Migration
Component: Migration → General

For address autofill the likely reason would be that it's only enabled for users in the U.S. and we probably triggered an update to the IP geolocation between 52 and 67 so now you are correctly identified as being in the U.S. but you weren't before. If you have a backup of your profile before the upgrade you could look at prefs.js for browser.search.countryCode and/or browser.search.region values.

prefs.js from release 67.0.4 has browser.search.region = US, same as in 68.0.1. Neither profile has browser.search.countryCode.

Component: General → Form Autofill
Product: Firefox → Toolkit

Given the answer to comment 3 this seems like an add-ons manager bug related to System Add-ons, not related to Form Autofill code.

Component: Form Autofill → Add-ons Manager
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.