1569467 - Footer of protection panel is cut on localized build

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Francesco Lodolo [:flod]]

Attachment: immagine.png

I assume it happens because the initial message spans on two lines.

Comment 1

[Francesco Lodolo [:flod]]

Interestingly enough, if you click the "Site not working?" link, and go back, the footer is fully displayed.

Comment 4

[Francesco Lodolo [:flod]]

This bug was duped against bug 1564077, but I'm still seeing the issue on 70.0a1 (2019-08-02) after the other bug was fixed.

The build is based on a changeset that includes that fix
https://hg.mozilla.org/mozilla-central/rev/5ced3811411e9b6f8f1ba02f518d0a5966a412af

Comment 5

[Francesco Lodolo [:flod]]

Attachment: immagine.png

Updated image with localized footer (landed in the past 24h).

Comment 6

[Johann Hofmann [:johannh]]

Yup, this one isn't on Andrew, though :)

Comment 7

[Johann Hofmann [:johannh]]

Attachment: Bug 1569467 - Avoid setting the "hidden" attribute on protections popup switch labels. r=nhnt11

We were hiding these labels by setting the "hidden" attribute by default and then, in CSS,
negating the effect of "hidden" by using display: unset;. Turns out this isn't a great
idea because doing this won't remove the "hidden" attribute, which some code relies on
to figure out whether the element is hidden. Like in this case PanelMultiview:
https://searchfox.org/mozilla-central/rev/0ffa9e372df56c95547fed9c3433ddec4fbf6f11/browser/components/customizableui/PanelMultiView.jsm#1402

Here it tries to find elements to process as part of descriptionHeightWorkaround,
and that skips this technically visible element because it still has the hidden attribute.

Luckily that's easy to fix.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e332c09026d
Avoid setting the "hidden" attribute on protections popup switch labels. r=nhnt11

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/8e332c09026d

Comment 10

[Alexandru Trif, Desktop QA [:atrif]]

Hello!
Reproduced the issue with Firefox 70.0a1 (20190728214940) it-build on Windows 10x64.
The issue is verified with 70.0a1 (20190728214940) on Windows 10x64. Tracking protection panel is correctly displayed.