Closed Bug 156953 Opened 24 years ago Closed 24 years ago

Plugins with no name or descriptions don't show up in about plugins

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file)

We have a plugin that has no name or description, and it doesn't display in about:plugins. The issue is that the plugin GetDescription and GetName APIs return the result of the DoCharsetConversion. They should return NS_OK, because name and description could be NULL. Patch attached.
Attached patch Fix for problemSplinter Review
Just return NS_OK
--->michael's got this
Assignee: beppe → mkaply
Keywords: patch
Comment on attachment 90982 [details] [diff] [review] Fix for problem r=peterl
Attachment #90982 - Flags: review+
Comment on attachment 90982 [details] [diff] [review] Fix for problem sr=jst
Attachment #90982 - Flags: superreview+
Attachment #90982 - Flags: approval+
Comment on attachment 90982 [details] [diff] [review] Fix for problem a=asa (on behalf of drivers) for checkin to 1.1
Checked in on trunk
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: