1569560 - Add tuning parameters for new malloc memory counter

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P1)

Description

[Jon Coppeard (:jonco)]

At the moment this uses the base parameter for the original malloc allocation counter and a fixed growth factor of 2. This bug will add individual parameters for these and set them to something the approximates the current behaviour.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1569560 - Simplify minimum heap growth factor limit r=sfink

We impose a minimum heap growth factor so that the new threshold must always be greater than the level at the end of a collection, otherwise we could get stuck endlessly collecting. The problem is that we can eagarly collect before we hit the threshold so this needs to be taken into account. At the moment we have two miminums though and we could simplifiy this to just a single one.

Depends on D39728

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1569560 - Add tuning parameters for new malloc counter r=sfink

This adds two new parameters. The growth fator is set to 1.5 and the base to 42MB. Trail and error showed that this latter value ended up triggering GCs roughtly in line with the old malloc counter. These values make the initial malloc threshold ~64MB.

Depends on D39729

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b0221b3e7ea
Simplify minimum heap growth factor limit r=sfink
https://hg.mozilla.org/integration/autoland/rev/c27a6d5810fe
Add tuning parameters for new malloc counter r=sfink

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9b0221b3e7ea
https://hg.mozilla.org/mozilla-central/rev/c27a6d5810fe