1569564 - Remove original malloc memory accounting framework

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P1)

Description

[Jon Coppeard (:jonco)]

Now that the more precise malloc tracking work has landed we should be able to remove the original framework.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1569564 - Remove runtime-wide malloc bytes counter as all uses are tracked separately r=sfink

First of all remove the runtime-wide malloc bytes tracking. There's only a few uses of this so it almost never triggers a collection, and most of these uses are tracked in other ways anyway.

Depends on D39730

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1569564 - Remove the original per-zone malloc counter r=sfink

Depends on D39731

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1569564 - Replace the JIT code counter using the new precise tracking infrastructure r=sfink

This replaces the original JIT code memory counter with one that tracks the allocated JIT code precisely. This now uses a fixed threshold which was the original intention.

This also removes the INCREMENTAL_MALLOC_TRIGGER GC reason and all GCs triggered by malloc allocations use TOO_MUCH_MALLOC, so whether a GC is incremental is separated from the trigger reason.

Depends on D39733

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1569564 - Remove the original malloc counter infrastructure r=sfink

Depends on D39734

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c0cf078b5497
Remove runtime-wide malloc bytes counter as all uses are tracked separately r=sfink
https://hg.mozilla.org/integration/autoland/rev/bda9fb62a8eb
Remove the original per-zone malloc counter r=sfink
https://hg.mozilla.org/integration/autoland/rev/86ec01cf8dac
Replace the JIT code counter using the new precise tracking infrastructure r=sfink
https://hg.mozilla.org/integration/autoland/rev/694c0c845fd5
Remove the original malloc counter infrastructure r=sfink

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/c0cf078b5497
https://hg.mozilla.org/mozilla-central/rev/bda9fb62a8eb
https://hg.mozilla.org/mozilla-central/rev/86ec01cf8dac
https://hg.mozilla.org/mozilla-central/rev/694c0c845fd5