Closed Bug 1569685 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 18155 - Do not throw errors in copyFromChannel/copyToChannel

Categories

(Core :: Web Audio, task, P4)

Product:
Core
Component:
Web Audio
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18155 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18155
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:

Do not throw errors in copyFromChannel/copyToChannel

If the buffer offset lies outside the boundaries of the AudioBuffer , silently
do nothing instead of throwing an error.

This is a change in behavior where we used to throw an error if the offset was greater
than or equal to the size of the AudioBuffer.

Spec issue: https://github.com/WebAudio/web-audio-api/issues/1884

Bug: 987295
Change-Id: I61955108af0fa3072a2c7174889827781c06747e
Reviewed-on: https://chromium-review.googlesource.com/1717185
WPT-Export-Revision: c377f675b886a191f20a51b96ab49f7ab42aa60a

Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 1 tests and 52 subtests
OK     : 1
PASS   : 47
FAIL   : 5

New tests that have failures or other problems:
/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel.html
    # AUDIT TASK RUNNER FINISHED: 2 out of 5 tasks were failed.: FAIL
    < [copyFrom-exceptions] 1 out of 9 assertions were failed.: FAIL
    < [copyTo-exceptions] 1 out of 8 assertions were failed.: FAIL
    X 4: buffer.copyToChannel(x, 0, -1) incorrectly threw IndexSizeError: "Index or size is negative or greater than the allowed amount".: FAIL
    X 5: buffer.copyFromChannel(x, 0, -1) incorrectly threw IndexSizeError: "Index or size is negative or greater than the allowed amount".: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c24c64722c
[wpt PR 18155] - Do not throw errors in copyFromChannel/copyToChannel, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/152817124d09
[wpt PR 18155] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f5c24c64722c
https://hg.mozilla.org/mozilla-central/rev/152817124d09

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.