1569685 - [wpt-sync] Sync PR 18155 - Do not throw errors in copyFromChannel/copyToChannel

Status: RESOLVED FIXED

(Core :: Web Audio, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 18155 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18155
Details from upstream follow.

Raymond Toy <[e-mail]> wrote:

Do not throw errors in copyFromChannel/copyToChannel

If the buffer offset lies outside the boundaries of the AudioBuffer , silently
do nothing instead of throwing an error.

This is a change in behavior where we used to throw an error if the offset was greater
than or equal to the size of the AudioBuffer.

Spec issue: https://github.com/WebAudio/web-audio-api/issues/1884

Bug: 987295
Change-Id: I61955108af0fa3072a2c7174889827781c06747e
Reviewed-on: https://chromium-review.googlesource.com/1717185
WPT-Export-Revision: c377f675b886a191f20a51b96ab49f7ab42aa60a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=53d873610c918ffb981a31a3679e9684429391f7

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3f24afe709e72284c3e8a19f7e6ad9d2f47b513

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6990d64945f12e35e9a9df75af3b08894b159556

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=3eb8f43adbe0ae3a16a86ede18d6c99cd7d1b025

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 52 subtests
OK     : 1
PASS   : 47
FAIL   : 5

New tests that have failures or other problems:
/webaudio/the-audio-api/the-audiobuffer-interface/audiobuffer-copy-channel.html
    # AUDIT TASK RUNNER FINISHED: 2 out of 5 tasks were failed.: FAIL
    < [copyFrom-exceptions] 1 out of 9 assertions were failed.: FAIL
    < [copyTo-exceptions] 1 out of 8 assertions were failed.: FAIL
    X 4: buffer.copyToChannel(x, 0, -1) incorrectly threw IndexSizeError: "Index or size is negative or greater than the allowed amount".: FAIL
    X 5: buffer.copyFromChannel(x, 0, -1) incorrectly threw IndexSizeError: "Index or size is negative or greater than the allowed amount".: FAIL

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c24c64722c
[wpt PR 18155] - Do not throw errors in copyFromChannel/copyToChannel, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/152817124d09
[wpt PR 18155] - Update wpt metadata, a=testonly

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/f5c24c64722c
https://hg.mozilla.org/mozilla-central/rev/152817124d09