Closed Bug 1569709 Opened 7 years ago Closed 7 years ago

add =cross options to --enable-profile* options

Categories

(Firefox Build System :: General, task)

task
Not set
normal

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 external file)

No description provided.

This change gives us the ability to selectively turn on cross-language
PGO, just like we have the ability to selectively turn on cross-language LTO.

There is room for things to go wrong here: it's not guaranteed that
--enable-profile-generate=cross will always be used with
--enable-profile-use=cross. Nothing bad will happen in the sense that
the build will succeed, but it's possible that we miss out on
optimizations on the Rust side. Either we fail to generate profile data
for the Rust code, or the Rust compiler fails to use the profile data.

In the future, we may want to default to cross-language PGO to avoid
these kind of mismatches.

Attachment #9081338 - Attachment description: Bug 1569709 - add --enable-profile-{use,generate}=cross option; r=#build → Bug 1569709 - add --enable-cross-pgo option; r=#build
Attachment #9081338 - Attachment description: Bug 1569709 - add --enable-cross-pgo option; r=#build → Bug 1569709 - add --enable-profile-{generate,use}=cross option; r=#build
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0775acfef6dc add --enable-profile-{generate,use}=cross option; r=mshal
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: