1569712 - Conexant Flow is instantiating a11y and harming system performance

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[Aaron Klotz [:aklotz]]

A user on Reddit is reporting a11y performance issues that are caused by this instantiator process:

  "accessibility": {
    "isActive": true,
    "forceDisabled": 0,
    "handlerUsed": true,
    "instantiator": "UNKNOWN|C:\\Program Files\\CONEXANT\\Flow\\Flow.exe"
  },

A quick Googling shows that it is installed as part of HP Audio drivers (?!), so this might be fairly common.

Comment 1

[James Teh [:Jamie]]

I can't think of any good reason Conexant Flow should be using accessibility. Furthermore, Asa did a bit of research and it looks like this tool has a history of rather concerning/careless/misguided behaviour; e.g. key logging, CPU spikes, etc. I think we should block this.

Comment 2

[jpooley]

HP has released an advisory for this issue, but the drivers are still not available online: https://support.hp.com/us-en/document/c06209366?hprpt_id=HPGL_ALERTS_2033325&jumpid=em_alerts_us-us_Feb19_xbu_all_all_1785815_2033325_DesktopsWorkstationsLaptopsandHybrids_critical__/

Comment 3

[jpooley]

Updating my above comment, the latest drivers available on the HP Support website for your product will resolve this issue. Specifically, the minimum version for the Audio Driver is 9.0.222.0, and the version I have confirmed works is 9.0.232.1 from sp95069. They removed the drivers linked in that article because there was a security flaw, according to the L3 tech I spoke to today.

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1569712: Block Conexant Flow instantiating a11y to prevent performance issues.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4bf4bab555b8
Block Conexant Flow instantiating a11y to prevent performance issues. r=MarcoZ

Comment 6

[Aaron Klotz [:aklotz]]

[Tracking Requested - why for this release]:
Serious perf issue that probably affects a lot of HP machines out in the wild. It would be nice to get this into 68.0.2.

Comment 7

[Aaron Klotz [:aklotz]]

[Tracking Requested - why for this release]:
Serious perf issue that probably affects a lot of HP machines out in the wild. It would be nice to get this into ESR68.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

My understanding is that this isn't a new issue in Fx68. While I understand that this is can be annoying for users, we generally try to scope dot release uplifts to new regressions in the release or other high-impact bugs. For that reason, I'm going to track this for Fx69 and 68.1esr shipping in about a month. Let me know if you feel strongly that this needs to be in 68.0.2 before then and we can discuss.

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/4bf4bab555b8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta and ESR68 approval when you get a chance.

Comment 11

[Aaron Klotz [:aklotz]]

Comment on attachment 9082160 [details]
Bug 1569712: Block Conexant Flow instantiating a11y to prevent performance issues.

Beta/Release Uplift Approval Request

• User impact if declined: Windows users running this particular third-party software may experience severe performance issues while running Firefox. Apparently this software is installed along with audio drivers on many HP devices, so this is likely pretty common.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch, added the third-party application to the a11y remote client blocklist.
• String changes made/needed:

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Performance issues.
• User impact if declined: Windows users running this particular third-party software may experience severe performance issues while running Firefox. Apparently this software is installed along with audio drivers on many HP devices, so this is likely pretty common.
• Fix Landed on Version: 70
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch, added the third-party application to the a11y remote client blocklist.
• String or UUID changes made by this patch: None

Comment 12

[Aaron Klotz [:aklotz]]

I took care of the nomination to get this up ASAP, since Jamie's workday won't start for a while yet.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9082160 [details]
Bug 1569712: Block Conexant Flow instantiating a11y to prevent performance issues.

Fixes a pretty big perf hit in some cases on HP systems. Approved for 69.0b11 and 68.1esr.

Comment 14

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/57aa25b9aa2b

Comment 15

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/09993a75b6c9