1569761 - Crash in [@ MapContentToWebShells]

Status: RESOLVED WORKSFORME

(Core :: Printing: Output, defect, P3)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-b6c47b4e-33a1-4331-906f-01dc20190725.

Seen while looking at nightly crash triage. Small volume Win regression which started in 20190724220024: https://bit.ly/2OocML3

Possible regression range based on Build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=69ac304560c98a733d44a0245fe9782dc6a465e2&tochange=1da5a37de0fd1695e96a9d5e7f59fbd84d8759b2

Bug 1567105 landed in that timeframe, as well as Bug 1568055. ni on Emilio and Nika

Top 10 frames of crashing thread:

0 xul.dll static void MapContentToWebShells layout/printing/nsPrintJob.cpp:434
1 xul.dll static void MapContentToWebShells layout/printing/nsPrintJob.cpp:449
2 xul.dll nsresult nsPrintJob::DoCommonPrint layout/printing/nsPrintJob.cpp:856
3 xul.dll nsresult nsPrintJob::CommonPrint layout/printing/nsPrintJob.cpp:707
4 xul.dll nsPrintJob::PrintPreview layout/printing/nsPrintJob.cpp:1056
5 xul.dll nsresult nsDocumentViewer::PrintPreview layout/base/nsDocumentViewer.cpp:3641
6 xul.dll XPTC__InvokebyIndex 
7  @0x2333cca026f 
8 xul.dll round 
9 xul.dll round 

Comment 1

[Emilio Cobos Álvarez (:emilio)]

My patch is quite unlikely to cause it.

Comment 2

[Marcia Knous [:marcia]]

All crash reports have about:printpreview as the URL.

Comment 3

[Pascal Chevrel:pascalc (PTO until Sept 2)]

4 crashes on nightly only and no crashes over the past 2 days, marking as fix-optional as it doesn't seem to be a worrying issue for 70.

Comment 4

[Marcia Knous [:marcia]]

Still fairly low volume on 70 - 4 crashes in the last few days.

Comment 5

[Cameron McCormack (:heycam)]

I think Nika's patch is more likely to be relevant than Emilio's.

Comment 6

[Marcia Knous [:marcia]]

Single crash back in early December - since then nothing. Closing as WFM.