Closed Bug 1569791 Opened 6 years ago Closed 6 years ago

Construct MozTreecolPicker menus with closemenu attribute if the column has it.

Categories

(Toolkit :: UI Widgets, task, P2)

Product:
Toolkit
Component:
UI Widgets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: alta88, Assigned: alta88)

References

Details

Attachments

(1 file, 1 obsolete file)

closemenu.patch
1.15 KB, patch
alta88
: review+
Details | Diff | Splinter Review

Motivated by Bug 545906.

Attached patch closemenu.patch (obsolete) — — Splinter Review

Victor, we don't use phab only in Tb and I don't have MFA on bmo, so have used NI here; hope it's ok.

Assignee: nobody → alta88
Flags: needinfo?(vporof)
Blocks: 545906
Comment on attachment 9081471 [details] [diff] [review] closemenu.patch Review of attachment 9081471 [details] [diff] [review]: ----------------------------------------------------------------- Applied locally, everything still seems to work fine. r+ with green try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc85d92607b04c73008e83f14cf109b0fe073296
Attachment #9081471 - Flags: review+
Attached patch closemenu.patch — — Splinter Review

wow, prettier wants an odd format. updated patch passes mach lint.

Attachment #9081471 - Attachment is obsolete: true
Attachment #9081963 - Flags: review+
Priority: -- → P2
Keywords: checkin-needed

Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d408d3d062c
Construct MozTreecolPicker menus with closemenu attribute if the column has it. r=vporof

Keywords: checkin-needed

https://hg.mozilla.org/mozilla-central/rev/8d408d3d062c

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Flags: needinfo?(vporof)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: