Closed Bug 1569829 Opened 5 years ago Closed 5 years ago

Opening a code-heavy file hangs to do 6 reflows with heavy codemirror computations

Categories

(DevTools :: Debugger, defect, P2)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: Harald, Assigned: jlast)

References

(Blocks 1 open bug)

Details

(Whiteboard: [debugger-reserve])

Attachments

(1 file)

Bug 1569829 - Opening a code-heavy file hangs to do 6 reflows with heavy codemirror computations. r=davidwalsh
47 bytes, text/x-phabricator-request
Details | Review

When pausing, a minified file got hit, causing a sequence of hangs that add up to 30sec.

One app to try this out is debugging Slack.

The hang is split in 6 code mirror updates, each taking 3.5 sec computation with a bit of reflow: https://perfht.ml/2Y8Sslw

As a start, we should find out why codemirror updates 6 times in a row (probably react state changes), which should then be combined into one update.

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task
Type: task → defect
Blocks: dbg-70
Whiteboard: [debugger-reserve]
No longer blocks: dbg-70
Whiteboard: [debugger-reserve]
Assignee: nobody → jlaster
Blocks: dbg-71
Status: NEW → ASSIGNED
Whiteboard: [debugger-reserve]
Pushed by jlaster@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/527ea600aba9 Opening a code-heavy file hangs to do 6 reflows with heavy codemirror computations. r=davidwalsh

https://hg.mozilla.org/mozilla-central/rev/527ea600aba9

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: