1570091 - Don't load scripts from the bytecode cache into globals with instrumentation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Brian Hackett [Laid off!]]

Bug 1554524 checks that we don't XDR-decode scripts into globals which use instrumentation (the XDR-encoded scripts won't have their bytecode modified as required by instrumentation). The DOM's ScriptLoader doesn't attempt to retry loading from source if it hits hits this case, however, and the script ends up not being loaded at all. It seems best to fix this by avoiding use of the bytecode cache when loading scripts into globals with instrumentation.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Bug 1570091 Part 1 - Add public API for whether a global has instrumentation enabled, r=tcampbell.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Bug 1570091 Part 2 - Don't use bytecode cache when loading scripts in globals with instrumentation, r=smaug.

Depends on D39932

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17136b0d9bb6
Part 1 - Add public API for whether a global has instrumentation enabled, r=tcampbell.
https://hg.mozilla.org/integration/autoland/rev/30a8df41ff6d
Part 2 - Don't use bytecode cache when loading scripts in globals with instrumentation, r=smaug,nbp.

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/17136b0d9bb6
https://hg.mozilla.org/mozilla-central/rev/30a8df41ff6d