Closed Bug 1570091 Opened 2 years ago Closed 2 years ago

Don't load scripts from the bytecode cache into globals with instrumentation

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: bhackett1024, Assigned: bhackett1024)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1554524 checks that we don't XDR-decode scripts into globals which use instrumentation (the XDR-encoded scripts won't have their bytecode modified as required by instrumentation). The DOM's ScriptLoader doesn't attempt to retry loading from source if it hits hits this case, however, and the script ends up not being loaded at all. It seems best to fix this by avoiding use of the bytecode cache when loading scripts into globals with instrumentation.

Priority: -- → P3
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17136b0d9bb6
Part 1 - Add public API for whether a global has instrumentation enabled, r=tcampbell.
https://hg.mozilla.org/integration/autoland/rev/30a8df41ff6d
Part 2 - Don't use bytecode cache when loading scripts in globals with instrumentation, r=smaug,nbp.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.