Closed Bug 1570158 Opened 4 months ago Closed 3 months ago

Add proxy information to candidates table in about:webrtc

Categories

(Core :: WebRTC, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: ralderete, Assigned: ralderete)

Details

Attachments

(1 file)

It would be convenient to have a field for each ICE candidate on about:webrtc that indicates whether that candidate is behind a proxy or not. That way users do not have to inspect packets via Wireshark or some other tool to determine which communications are through a proxy.

Assignee: nobody → ralderete

This adds a field to about:webrtc which indicates whether an associated
candidate is behind a proxy or not.

It seems to me a on-going task. Set the priority to P2 for now. Feel free to change it.

Priority: -- → P2

Added a couple more review comments, should be fine after those are done.

Keywords: checkin-needed

Tried to land, but got: "applying /tmp/tmpsdUV74 2 out of 2 hunks ignored -- saving rejects to file media/mtransport/nricectx.cpp.rej abort: patch command failed: exited with status 256"

Flags: needinfo?(ralderete)

(In reply to Bogdan Tara[:bogdan_tara] from comment #4)

Tried to land, but got: "applying /tmp/tmpsdUV74 2 out of 2 hunks ignored -- saving rejects to file media/mtransport/nricectx.cpp.rej abort: patch command failed: exited with status 256"

I'm not totally sure what caused this, but it may have been an issue with whitespace in that file. I've modified that out of the diff, so hopefully that makes it ready to land.

Flags: needinfo?(ralderete)
Keywords: checkin-needed

Ryan, you need to update the commit message to contain one of the below reviewers:
Please, request review from either: remote: - Andrea Marchesini (:baku) remote: - Andreas Farre (:farre) remote: - Andrew McCreight (:mccr8) remote: - Bobby Holley (:bholley) remote: - Boris Zbarsky (:bz) remote: - Ehsan Akhgari (:ehsan) remote: - Henri Sivonen (:hsivonen) remote: - Nika Layzell (:mystor) remote: - Olli Pettay (:smaug) remote: - Peter Van der Beken (:peterv)

hg error in cmd: hg push -r tip upstream: pushing to ssh://hg.mozilla.org/integration/autoland searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 14 changes to 14 files remote: remote: ******************************* ERROR ******************************* remote: Changeset c4c94dd05ecf alters WebIDL file(s) without DOM peer review: remote: dom/webidl/RTCStatsReport.webidl remote: remote: Please, request review from either: remote: - Andrea Marchesini (:baku) remote: - Andreas Farre (:farre) remote: - Andrew McCreight (:mccr8) remote: - Bobby Holley (:bholley) remote: - Boris Zbarsky (:bz) remote: - Ehsan Akhgari (:ehsan) remote: - Henri Sivonen (:hsivonen) remote: - Nika Layzell (:mystor) remote: - Olli Pettay (:smaug) remote: - Peter Van der Beken (:peterv) remote: ********************************************************************* remote: remote: transaction abort! remote: rollback completed remote: pretxnchangegroup.mozhooks hook failed abort: push failed on remote

Flags: needinfo?(ralderete)
Keywords: checkin-needed
Flags: needinfo?(ralderete)
Keywords: checkin-needed

Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8f803211fda5
Add proxy information to candidates table in about:webrtc r=bwc,baku

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.