1570159 - URL classifier doesn't classify URL when its top level window is about page

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P2)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1570159. Silence some warning spam in url classifier code. r?dimi

I see these a lot and it makes it hard to find warnings or assertions that may be relevant to the code I'm working on.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The product::component has been changed since the backlog priority was decided, so we're resetting it.
For more information, please visit auto_nag documentation.

Comment 3

[Dimi Lee [:dimi]]

Most of the warnings seem related to whitelist.
Timothy, can you help upload a log with MOZ_LOG="nsChannelClassifier", I want to know if we can eliminate this without removing NS_WARN

Comment 4

[Timothy Nikkel (:tnikkel)]

Sure I can do that tomorrow. Do you not see these warnings in your local builds? I see them on all my machines (2 Windows, 1 linux, 1 mac).

Comment 5

[Dimi Lee [:dimi]]

(In reply to Timothy Nikkel (:tnikkel) from comment #4)

Sure I can do that tomorrow. Do you not see these warnings in your local builds? I see them on all my machines (2 Windows, 1 linux, 1 mac).

No, I tried(but didn't really spend a lot of time trying) and didn't see it.
I just back from a long PTO so maybe my build is out-of-date or something.

Comment 6

[Timothy Nikkel (:tnikkel)]

Attachment: urllog

Here is a log from opening the browser, going to google and performing a search. Note that I opened the browser a couple of times before this to make sure everything was initialized in case that matters.

Comment 7

[Dimi Lee [:dimi]]

Hi Timothy
It looks like those errors occurred while loading sites in about:home (can't get the hostname of top-level window about:home)
My local build doesn't trigger any network load while opening about:home , can you help confirm this issue happens in your build while opening about:home? thanks!

Comment 8

[Timothy Nikkel (:tnikkel)]

Yeah, the warnings come up (at least) when I open about:home.

Comment 9

[Timothy Nikkel (:tnikkel)]

Perhaps the difference in our location causes about:home to be different? Could you use a proxy to north america to reproduce?

Comment 10

[Timothy Nikkel (:tnikkel)]

Attachment: empty.html

Reloading this file triggers one of the warnings. Specifically

https://searchfox.org/mozilla-central/rev/ab6f4c453d15ab82147c630a8b886b40240ca72b/netwerk/url-classifier/UrlClassifierCommon.cpp#311

pageHostname is the empty string and resourceDomain is imageshack.com

Comment 11

[Dimi Lee [:dimi]]

Hi Timothy,
Thank for providing information on this bug.
I intend to fix this by handling these special cases. Those warning messages actually help because they lead us to this bug :)
And if you don't mind, I'll steal this bug from you.

Comment 12

[Dimi Lee [:dimi]]

Attachment: Bug 1570159 - CreatePairwiseWhitelistURI return success when it cannot get host from the top-level page. r?ehsan

When the top-level page is an about page, UrlClassifeirCommon::CreatePairwiseWhitelistURI
returns an error because |GetHost| call fails.
Since we don't have a pairwise whitelist URI whose top-level page is an
about page, we could just skip an about page in this case.

Note that the lookup against blacklist tables will still be performed, we
just skip looking for a match in whitelist tables.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec5ffc5cb2a8
CreatePairwiseWhitelistURI return success when it cannot get host from the top-level page. r=Ehsan

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ec5ffc5cb2a8