1570179 - nsXREDirProvider can leak nsLocalFiles in some cases

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Dave Townsend [:mossop]]

nsXREDirProvider caches a couple of the lookup results (https://searchfox.org/mozilla-central/rev/38c88cbf4be87dfa0636d15a5d3599a8ea0d1a72/toolkit/xre/nsXREDirProvider.cpp#101). These are cleared during shutdown (https://searchfox.org/mozilla-central/rev/38c88cbf4be87dfa0636d15a5d3599a8ea0d1a72/toolkit/xre/nsXREDirProvider.cpp#1076) but then we trigger various observer notifications to tell quite a lot of other things to shutdown, any of which has the chance to call the directory service which ends up re-caching those results.

It turns out that telemetry is one of those things and so in the right circumstances we pick up an nsLocalFile and nsStringBuffer leak. I don't actually understand why it isn't a problem right now, but a patch I have that does completely irrelevant stuff triggers this.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1570179: Clear cached directories after sending shutdown notifications. r=froydnj

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2c7c870b120
Clear cached directories after sending shutdown notifications. r=froydnj

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f2c7c870b120