1570256 - 4.9 - 5.67% tsvgx (linux64-shippable-qr, windows10-64-shippable-qr) regression on push 5671bf0f8a214d690b4754aab8e6304102c1b791

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Ionuț Goldan [:igoldan]]

Talos has detected a Firefox performance regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=45b70994ec2887b80c7463791a7b7b3013a13836&tochange=5671bf0f8a214d690b4754aab8e6304102c1b791

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

6% tsvgx windows10-64-shippable-qr opt e10s stylo 179.55 -> 189.74
5% tsvgx linux64-shippable-qr opt e10s stylo 237.78 -> 249.42

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=21912

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the Talos jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Tests

For information on reproducing and debugging the regression, either on try or locally, see: https://wiki.mozilla.org/Performance_sheriffing/Talos/Running

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Our wiki page outlines the common responses and expectations: https://wiki.mozilla.org/Performance_sheriffing/Talos/RegressionBugsHandling

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1570256. Revert the adjustment of the visible rect from bug 1565904.

This change was unintentional and may be responsible for the performance regression seen in
bug 1570256.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

This looks to be fixed by bug 1570399

Comment 3

[Pascal Chevrel:pascalc]

Ionuț , could you confirm that this is indeed fixed? Thanks

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Emailed as followup.

Comment 5

[Ionuț Goldan [:igoldan]]

(In reply to Pascal Chevrel:pascalc (pto Jul 12-30) from comment #3)

Ionuț , could you confirm that this is indeed fixed? Thanks

Yes, I confirm the regression was 100% fixed.

== Change summary for alert #22297 (as of Tue, 06 Aug 2019 12:22:29 GMT) ==

Improvements:

5% tsvgx windows10-64-shippable-qr opt e10s stylo 189.87 -> 180.45
4% tsvgx linux64-shippable-qr opt e10s stylo 251.95 -> 242.49

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=22297