1570266 - Typing % in the url bar does not search synced tabs

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[clessili]

Attachment: Capture.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

Type '%' followed by the title of a synced tab.

Actual results:

No synced tabs appear.

Expected results:

Typing keywords without '%' suggests synced tabs and open tabs.

With '%', the dropdown should list synced tabs along with open tabs.

Comment 1

[Marco Bonardo [:mak]]

Is this a regression (used to work, now it's broken), or an enhancement request?

Comment 2

[clessili]

Enhancement request, I don't think it ever worked.

Comment 3

[Drew Willcoxon :adw]

Seems like it should work: https://searchfox.org/mozilla-central/rev/b38e3beb658b80e1ed03e0fdf64d225bd4a40327/toolkit/components/places/UnifiedComplete.jsm#1087

Comment 4

[Marco Bonardo [:mak]]

The first problem is how we match, we pass the original search string "%" to getMatches, and then match on it, rather than just returning all the entries:
https://searchfox.org/mozilla-central/rev/b38e3beb658b80e1ed03e0fdf64d225bd4a40327/toolkit/components/places/PlacesRemoteTabsAutocompleteProvider.jsm#144

There is also the question of how to handle clash with local tabs, maybe only return a max of (maxRichResults/2) remote tabs? Because they will push away local tabs completely (if you have 10 remote tabs). Like in other cases we should add a few results, put the others aside, and if we don't find local tabs, add back the reserved ones.

Finally, Remote tabs are returned only if they were visited on mobile in the last 72 hours, for example in my case PlacesRemoteTabsAutocompleteProvider.getMatches("%") returns one entry, but it's older than 72 hours, thus I don't see it.

So, I think the only problem is handling the special restriction char in getMatches, and putting a limit.

Comment 6

[:Atoll]

Note that in my duped-here bug 1575558, I have only two Firefox Desktop instances linked to my FxA, and so

Remote tabs are returned only if they were visited on mobile in the last 72 hours

it may be that "on mobile" is instead "on another Firefox instance"?

Comment 7

[Harry Twyford]

Engineering discussed this with Verdi. There are some difficulties with this bug because we don't have a way to sort open tab and remote tab results together, since Desktop and mobile use different frecency scales. Short of that, we're just going to show up to 5 remote tab results and maxRichResults - numberOfRemoteResults open tab results, with all of the remote tab results appearing after the open tab results. We can tweak this behaviour once we have an initial implementation.

Comment 8

[Marco Bonardo [:mak]]

I think currently remote tabs appear above other results (TBV)

Comment 9

[Harry Twyford]

Also, it probably makes more sense to show maximum maxRichResults / 2 remote tab results rather than 5, to accommodate edge cases where people have changed maxRichResults.

Comment 10

[Harry Twyford]

Attachment: Bug 1570266 - Return remote tab results for searches for '%'. r?adw

Comment 11

[Harry Twyford]

Like Marco said in comment 4, the issue here is that we pass the "%" character to PlacesRemoteTabsAutocompleteProvider.getMatches. We should pass the search tokens instead.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60a406d3b53a
Return remote tab results for searches for '%'. r=adw

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/60a406d3b53a

Comment 14

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this issue using 70.0a1 (2019-07-31) on Windows 10 x64.
I can confirm the fix, I verified using Fx 78.0 on Windows 10 x64 and macOS 10.13.