1570330 - Make test_doorhanger_homepage_button (in browser_ext_chrome_settings_overrides_home.js) wait on page load before moving to next task

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect, P2)

Description

[Peter Van der Beken [:peterv]]

We're running into a test failure in browser/components/extensions/test/browser/browser_ext_chrome_settings_overrides_home.js with session history running in the parent.
I've debugged it, what looks to be happening is that in test_doorhanger_homepage_button the preference observer for the homepage pref in browser/components/extensions/parent/ext-chrome-settings-overrides.js (in beforeDisableAddon in the lazy getter for homepagePopup) doesn't necessarily finish before the test moves to the next task (test_doorhanger_new_window). The tests does wait for the homepage pref to be changed (await prefPromise), but that doesn't mean the observer in ext-chrome-settings-overrides.js is done. The observer in ext-chrome-settings-overrides.js ends up doing something to the popup, and confuses the next test (test_doorhanger_new_window).

Session history running in the parent makes the test fail, because it adds a bunch of sync IPC that ends up delaying the pref observer running enough to trigger this. But it seems there might be other ways to trigger it. Making the test wait for the new homepage to be loaded seems to fix the test.

Comment 1

[Peter Van der Beken [:peterv]]

Attachment: Bug 1570330 - Make test_doorhanger_homepage_button (in browser_ext_chrome_settings_overrides_home.js) wait on page load before moving to next task. r?gijs!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d02248cec4c0
Make test_doorhanger_homepage_button (in browser_ext_chrome_settings_overrides_home.js) wait on page load before moving to next task. r=Gijs

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d02248cec4c0

Comment 4

[Miruna Curtean]

Does this issue require manual QA? If so, please add the "qe verify +" flag and the steps to reproduce.
If it does not, then please update it using the "qe verify -" flag.
Thank you

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/eb30f2268ed6