Make test_doorhanger_homepage_button (in browser_ext_chrome_settings_overrides_home.js) wait on page load before moving to next task
Categories
(WebExtensions :: Frontend, defect, P2)
Tracking
(Fission Milestone:M4, firefox-esr60 unaffected, firefox-esr68 fixed, firefox68 wontfix, firefox69 wontfix, firefox70 fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | fixed |
| firefox68 | --- | wontfix |
| firefox69 | --- | wontfix |
| firefox70 | --- | fixed |
People
(Reporter: peterv, Assigned: peterv)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
We're running into a test failure in browser/components/extensions/test/browser/browser_ext_chrome_settings_overrides_home.js with session history running in the parent.
I've debugged it, what looks to be happening is that in test_doorhanger_homepage_button the preference observer for the homepage pref in browser/components/extensions/parent/ext-chrome-settings-overrides.js (in beforeDisableAddon in the lazy getter for homepagePopup) doesn't necessarily finish before the test moves to the next task (test_doorhanger_new_window). The tests does wait for the homepage pref to be changed (await prefPromise), but that doesn't mean the observer in ext-chrome-settings-overrides.js is done. The observer in ext-chrome-settings-overrides.js ends up doing something to the popup, and confuses the next test (test_doorhanger_new_window).
Session history running in the parent makes the test fail, because it adds a bunch of sync IPC that ends up delaying the pref observer running enough to trigger this. But it seems there might be other ways to trigger it. Making the test wait for the new homepage to be loaded seems to fix the test.
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
||
Updated•5 years ago
|
Pushed by pvanderbeken@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d02248cec4c0 Make test_doorhanger_homepage_button (in browser_ext_chrome_settings_overrides_home.js) wait on page load before moving to next task. r=Gijs
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
|
||
Comment 4•5 years ago
|
||
Does this issue require manual QA? If so, please add the "qe verify +" flag and the steps to reproduce.
If it does not, then please update it using the "qe verify -" flag.
Thank you
|
||
Updated•5 years ago
|
|
|
||
Comment 5•5 years ago
|
||
| bugherder uplift | ||
|
|
||
Updated•2 years ago
|
Description
•