1570337 - Android implementation of PlatformEncoderModule.

Status: RESOLVED FIXED

(Core :: Audio/Video, task, P2)

Description

[John Lin [:jhlin][:jolin]]

Follow up of bug 1425277.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1570337 - p1: singletonize sPEMLog. r=jya

Comment 2

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1570337 - p2: extend and expose H.264 utility functions. r=jya

Some existing functions that manipulates H.264 bitstream already cover
most of the efforts for converting Android encoder output. With some minor
changes, they can be called by the encoder to avoid code duplications.

Depends on D43685

Comment 3

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1570337 - p4: implement Android encoder. r=jya

Depends on D43686

Comment 4

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1570337 - p5: test initializing encoder both w/ and w/o specific parameters. r=jya

Depends on D43687

Comment 5

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1570337 - p6: repeat calling Drain() until no more output. r=jya

Existing tests will fail when there are more than 1 pending frames when Drain()
is called. Repeatly calling it to ensure all frames will be collected.

Depends on D43688

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9ee134756e92
p1: singletonize sPEMLog. r=jya
https://hg.mozilla.org/integration/autoland/rev/1d0871b5c1d6
p2: extend and expose H.264 utility functions. r=jya
https://hg.mozilla.org/integration/autoland/rev/ca5a747f59d9
p3: implement Android encoder. r=jya
https://hg.mozilla.org/integration/autoland/rev/1c7be21d77b9
p4: test initializing encoder both w/ and w/o specific parameters. r=jya
https://hg.mozilla.org/integration/autoland/rev/36f045ffd19f
p5: repeat calling Drain() until no more output. r=jya

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 5 changesets (Bug 1570337) for breaking Android builds in AndroidEncoderModule.cpp CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=264820618&resultStatus=testfailed%2Cbusted%2Cexception&revision=36f045ffd19f78657f780af8f1c1a6272b36af7f&searchStr=android

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264820626&repo=autoland&lineNumber=23219

Backout: https://hg.mozilla.org/integration/autoland/rev/61bd4f42e7e6b486e19112cfdb722c09f6df3193

Comment 8

[John Lin [:jhlin][:jolin]]

Oops! I accidentally missed a patch in my local queue. :$
Will include that and submit again for reviewing. Sorry for the trouble!

Comment 9

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1570337 - p6: rename shared class and mothods. r?jya

All MP4Decoder utility functions can be shared by encoder. Rename
the class to avoid code duplication.

Depends on D43689

Comment 10

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1570337 - p7: fix build error/warning for UNIFIED_SOURCES. r?jya

Depends on D44587

Comment 11

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1570337 - p3: extract method for reuse. r?jya

Depends on D43686

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28c59c800b76
p1: singletonize sPEMLog. r=jya
https://hg.mozilla.org/integration/autoland/rev/5f22b364fffa
p2: extend and expose H.264 utility functions. r=jya
https://hg.mozilla.org/integration/autoland/rev/f98eb813a0e5
p3: extract method for reuse. r=jya
https://hg.mozilla.org/integration/autoland/rev/1fee7e3711e8
p4: implement Android encoder. r=jya
https://hg.mozilla.org/integration/autoland/rev/ef026d642642
p5: test initializing encoder both w/ and w/o specific parameters. r=jya
https://hg.mozilla.org/integration/autoland/rev/46ac027113e1
p6: repeat calling Drain() until no more output. r=jya
https://hg.mozilla.org/integration/autoland/rev/3fac005abec8
p7: fix build error/warning for UNIFIED_SOURCES. r=jya

Comment 13

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on AndroidDataEncoder.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/c24e2567d7e2888b932f2d753b31b04bc91ec9c3
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266222282&repo=autoland&lineNumber=23035

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8eb04002df3d
p1: singletonize sPEMLog. r=jya
https://hg.mozilla.org/integration/autoland/rev/fd48477b3dce
p2: extend and expose H.264 utility functions. r=jya
https://hg.mozilla.org/integration/autoland/rev/d8ea2a15e380
p3: extract method for reuse. r=jya
https://hg.mozilla.org/integration/autoland/rev/c5fc0c691fcc
p4: implement Android encoder. r=jya
https://hg.mozilla.org/integration/autoland/rev/becf46627f86
p5: test initializing encoder both w/ and w/o specific parameters. r=jya
https://hg.mozilla.org/integration/autoland/rev/e5e097a93970
p6: repeat calling Drain() until no more output. r=jya
https://hg.mozilla.org/integration/autoland/rev/67d64efc2ad7
p7: fix build error/warning for UNIFIED_SOURCES. r=jya

Comment 15

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8eb04002df3d
https://hg.mozilla.org/mozilla-central/rev/fd48477b3dce
https://hg.mozilla.org/mozilla-central/rev/d8ea2a15e380
https://hg.mozilla.org/mozilla-central/rev/c5fc0c691fcc
https://hg.mozilla.org/mozilla-central/rev/becf46627f86
https://hg.mozilla.org/mozilla-central/rev/e5e097a93970
https://hg.mozilla.org/mozilla-central/rev/67d64efc2ad7