157038 - Password Manager dialog not being updated

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, defect, P2)

Description

[Stephen P. Morse]

Now that password manager dialog has been changed from modal to non-modal, the 
display needs to be updated dynamically whenever the password list changes 
(e.g., when new logins are accepted).

See bug 156922 for similar problem with cookie manager.

Comment 1

[Stephen P. Morse]

Attachment: dynamically update password-manager display

Comment 2

[jag (Peter Annema)]

Comment on attachment 91559 [details] [diff] [review]
dynamically update password-manager display

sr=jag

Same thing applies here, use NS_LITERAL_STRING("...") instead of
NS_ConvertASCIItoUCS2("...").

Comment 3

[Stephen P. Morse]

Attachment: NS_ConvertASCIItoUCS2 changed to NS_LITERAL_STRING

Comment 4

[Stephen P. Morse]

Comment on attachment 91588 [details] [diff] [review]
NS_ConvertASCIItoUCS2 changed to NS_LITERAL_STRING

r=jag (brought forward)

Comment 5

[Stephen P. Morse]

Comment on attachment 91588 [details] [diff] [review]
NS_ConvertASCIItoUCS2 changed to NS_LITERAL_STRING

oops, I meant sr=jag (brought forward)

Comment 6

[Samir Gehani]

Comment on attachment 91588 [details] [diff] [review]
NS_ConvertASCIItoUCS2 changed to NS_LITERAL_STRING

r=sgehani

Comment 7

[Stephen P. Morse]

One clarification.  Line 1907 in singsign.cpp which in the latest patch reads

   os->NotifyObservers
      (nsnull, "signonChanged", NS_LITERAL_STRING(state).get());

should instead read

   os->NotifyObservers
      (nsnull, "signonChanged", NS_ConvertASCIItoUCS2(state).get());

I got a little too overzelous in interpreting jag's comments when I converted 
the patch in comment 1 to the patch in comment 3.

Comment 8

[Stephen P. Morse]

One more minor correction.  In nsPasswordManager.cpp the patch shows:

   return ::SINGSIGN_RemoveUser(PromiseFlatCString(aHost).get(),
-                               PromiseFlatString(aUser).get());
+                               PromiseFlatString(aUser).get(), PR_FALSE);

The added parameter should be PR_TRUE instead of PR_FALSE.  This controls 
whether or not update notifications get sent when the password manager is 
directed to remove a user.  Without a PR_TRUE here, the dialog will not get 
updated.

Comment 9

[Stephen P. Morse]

Fix checked in on trunk