1570402 - [RTL] Warning icon overlapping text on the screen sharing popup prompt

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P3)

Description

[Itiel]

Attachment: Screenshot

Using Windows 10, latest Nightly.

STR:

1. In about:config set intl.uidirection to 1 and restart Nightly
2. Open https://permission.site/
3. Click "Screen Share"
4. Observe the warning icon on yellow part of the popup promt

AR:
Warning icon overlapping text.

ER:
Not overlapping.

See attached.

Comment 1

[Itiel]

Adding this:

#webRTC-previewWarning:-moz-locale-dir(rtl) {
  background-position: calc(100% - .75em) .75em;
}

Somewhere around here:
https://searchfox.org/mozilla-central/source/browser/themes/shared/notification-icons.inc.css#214

... fixes this for me.

Johann, does that look okay to you?

Comment 2

[Johann Hofmann [:johannh]]

Hey, thanks for the analysis, I would happily take a patch for that :)

Comment 3

[Itiel]

Attachment: Bug 1570402 - [RTL] Fix overlapping icon on text on the screen sharing popup prompt

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a57a822a2df
[RTL] Fix overlapping icon on text on the screen sharing popup prompt r=johannh

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5a57a822a2df

Comment 6

[Itiel]

Fixed on Nightly.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Beta uplift?

Comment 8

[Itiel]

Comment on attachment 9083362 [details]
Bug 1570402 - [RTL] Fix overlapping icon on text on the screen sharing popup prompt

Beta/Release Uplift Approval Request

• User impact if declined: Warning icon overlapping text on the screen sharing popup prompt for RTL users
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 3 lines CSS code addition to position the icon on the right, for RTL users only
• String changes made/needed: None

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9083362 [details]
Bug 1570402 - [RTL] Fix overlapping icon on text on the screen sharing popup prompt

Simple RTL CSS fix. Approved for 69.0b14.

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5d9128d7056f