Fix font-size values in the protections panel
Categories
(Firefox :: Protections UI, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: johannh, Assigned: timhuang)
References
Details
(Whiteboard: [privacy-panel][skyline])
Attachments
(1 file)
In the spec all the fonts have the same size, while in the real protection panel I feel like some text is smaller than others. They might be missing from the infamous 110% rule.
We should go through it and add selectors as appropriate.
|
||
Comment 1•5 years ago
|
||
(In reply to Johann Hofmann [:johannh] from comment #0)
In the spec all the fonts have the same size, while in the real protection panel I feel like some text is smaller than others. They might be missing from the infamous 110% rule.
We should go through it and add selectors as appropriate.
Why would you try to target every single element rather than setting the font-size on a common container?
|
|
||
Comment 2•5 years ago
|
||
I can confirm that the font-sizes are inconsistent, it's not just your feeling.
|
Reporter | |
Comment 3•5 years ago
|
||
It would be nice to have a common container font size but I tried this once a while ago and it broke sizing of, uh, things (I don't exactly remember), so I abandoned it. Maybe we'll have better luck this time. Certainly worth a try!
|
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
This patch adds a css rule 'font-size' to the protection panel in order
to set size to the all strings in the protection panel.
Pushed by tihuang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/79ee8db4c841 Set the font-size to the protection panel. r=nhnt11,dao
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•