1570624 - Fix font-size values in the protections panel

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Johann Hofmann [:johannh]]

In the spec all the fonts have the same size, while in the real protection panel I feel like some text is smaller than others. They might be missing from the infamous 110% rule.

We should go through it and add selectors as appropriate.

Comment 1

[Dão Gottwald [:dao]]

(In reply to Johann Hofmann [:johannh] from comment #0)

In the spec all the fonts have the same size, while in the real protection panel I feel like some text is smaller than others. They might be missing from the infamous 110% rule.

We should go through it and add selectors as appropriate.

Why would you try to target every single element rather than setting the font-size on a common container?

Comment 2

[Dão Gottwald [:dao]]

I can confirm that the font-sizes are inconsistent, it's not just your feeling.

Comment 3

[Johann Hofmann [:johannh]]

It would be nice to have a common container font size but I tried this once a while ago and it broke sizing of, uh, things (I don't exactly remember), so I abandoned it. Maybe we'll have better luck this time. Certainly worth a try!

Comment 4

[Tim Huang[:timhuang]]

Attachment: Bug 1570624 - Set the font-size to the protection panel. r?nhnt11!

This patch adds a css rule 'font-size' to the protection panel in order
to set size to the all strings in the protection panel.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79ee8db4c841
Set the font-size to the protection panel. r=nhnt11,dao

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/79ee8db4c841