1570626 - Protections panel isn't wide enough

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Johann Hofmann [:johannh]]

In the spec it seems to be 400px wide, while at least in my Nightly it's 365px.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1570626 - Change the panel width size of the protections panel. r?nhnt11!

This patch changes the width size of the protections panel from '33rem'
to '33em'. This change will make the size of the proteciton panel wider
in order to match the spec.

Depends on D40787

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f759a4a34132
Change the panel width size of the protections panel. r=nhnt11

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f759a4a34132

Comment 4

[Md. Majedul islam]

I have reproduced this bug with Nightly 70.0a1 (2019-08-01) on windows 10, 64 bit!

The fix is now verified on Latest beta 70.0b9

Build ID : 20190923154733
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Comment 5

[Anca Soncutean, Desktop QA]

Not sure if this issue targets only the mac platforms. I’ve reproduce the issue on macOS 10.14 with Fx 70.0a1 (2019-08-01) and had the 365px width for the protection panel. With the latest Nightly (2019-10-15) / RC (70.0) I can measure 400px as per comment 1.
But I have different results on the other platforms: Windows 10 x64 (old build - 400px, latest build- 440px) Ubuntu 18.04 x64 (old build - 480px, latest build - 455px). What is the expected width for Windows, respectively Ubuntu? Thank you!

Comment 6

[Johann Hofmann [:johannh]]

Nihanth, can you take a look at that question? I know you were working on too-large panels on Ubuntu. Note sure about Windows.

Thanks! :)

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

The panel width is now set in em, so the overall layout of the panel should be preserved across platforms. The width is expected to vary due to different default font-sizes. 30.81em was calculated based on the ratio between panel width and font-size in the spec.

This is just the theory though. I'll take a look on Ubuntu, but it may take me a while to look at this on Windows since I don't have a machine set up at the moment (not even a VM unfortunately)

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

On Ubuntu, the ~450px width seems proportional to the 14px default font size. With Ubuntu's default font, 30em seems to correspond to a width of 400px, so it's slightly wider than it should be since we're using a value of 30.8em.