1570627 - Protections panel doesn't open on reader mode, about:, view-source:, etc.

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Johann Hofmann [:johannh]]

STR: Go to about:about and try to open the protections panel. It doesn't open. Now, whether this specific page should have a protections panel is a different question, but there are definitely some non-http pages that need to have it supported, and it shouldn't fail in this way.

The console displays an error in ContentBlockingAllowList.jsm

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to Johann Hofmann [:johannh] from comment #0)

STR: Go to about:about and try to open the protections panel. It doesn't open. Now, whether this specific page should have a protections panel is a different question, but there are definitely some non-http pages that need to have it supported, and it shouldn't fail in this way.

The console displays an error in ContentBlockingAllowList.jsm

Could you elaborate on which non-http pages need it to be supported? Can we perhaps document this somewhere, and maybe it needs to be tested?

Comment 2

[Johann Hofmann [:johannh]]

(In reply to Nihanth Subramanya [:nhnt11] from comment #1)

(In reply to Johann Hofmann [:johannh] from comment #0)

STR: Go to about:about and try to open the protections panel. It doesn't open. Now, whether this specific page should have a protections panel is a different question, but there are definitely some non-http pages that need to have it supported, and it shouldn't fail in this way.

The console displays an error in ContentBlockingAllowList.jsm

Could you elaborate on which non-http pages need it to be supported? Can we perhaps document this somewhere, and maybe it needs to be tested?

So, the one that comes to my mind right away is moz-extension://, the rest could be okay to just hide the shield icon, but I think the best course of action right now is fix the opening of that panel in the short term and as a follow-up determine where we can hide the icon.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

(In reply to Johann Hofmann [:johannh] from comment #2)

(In reply to Nihanth Subramanya [:nhnt11] from comment #1)

(In reply to Johann Hofmann [:johannh] from comment #0)

STR: Go to about:about and try to open the protections panel. It doesn't open. Now, whether this specific page should have a protections panel is a different question, but there are definitely some non-http pages that need to have it supported, and it shouldn't fail in this way.

The console displays an error in ContentBlockingAllowList.jsm

Could you elaborate on which non-http pages need it to be supported? Can we perhaps document this somewhere, and maybe it needs to be tested?

So, the one that comes to my mind right away is moz-extension://, the rest could be okay to just hide the shield icon, but I think the best course of action right now is fix the opening of that panel in the short term and as a follow-up determine where we can hide the icon.

I agree, the console error is likely trivial to fix. Thanks for filing this.

Comment 4

[Johann Hofmann [:johannh]]

Attachment: Bug 1570627 - Don't show the protections icon on sites where content blocking can't set exceptions. r=nhnt11

Showing the protection panel for pages where content blocking can't add exceptions and/or
the url classifier can't classify doesn't make sense and would just be confusing to the user
and our code.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16bddf4c8023
Don't show the protections icon on sites where content blocking can't set exceptions. r=nhnt11

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/16bddf4c8023

Comment 7

[Vlad Lucaci, Desktop QA (:vlucaci)]

Confirming this issue as verified fixed on 70.0a1 (2019-08-19) with Windows 10x64 , Ubuntu 18.04 and macOS 10.14.6. The Protections panel is no longer displayed for pages where content blocking can't add exceptions and/or .the url classifier can't classify