1570657 - Allow to perform up-to-date check of revisions before or instead of submitting to Phabricator

Status: RESOLVED DUPLICATE of bug 1481543

(Conduit :: moz-phab, enhancement)

Description

[Simon Giesecke [:sg] [he/him]]

h1. Current behaviour

Currently calling moz-phab, submitting the patches, and then running moz-phab again, stills shows the same revisions, even though nothing has changed after they were submitted:

[osboxes@sigiesec-mozbln mozilla-unified]$ moz-phab
Submitting 4 commits for review:
(D40181) 543462:77ba5dc4fde9 Bug 1566758 - Replaced two uses of IDBFactory.open(name, options) by IDBFactory.open(name, version) where only version was present in options r=ttung
(D40180) 543461:0c331ab6a500 Bug 1566758 - Added telemetry for use of IDBFactory.open(name, options) discriminated by principal types r=ttung
(D40179) 543448:f94dacebf4cf Bug 1566758 - Remove obsolete telemetry definitions r=ttung
(D40178) 543444:c8ca55504786 Bug 1566758 - Removed obsolete IDB_TYPE_PERSISTENT_COUNT and IDB_TYPE_TEMPORARY_COUNT telemetry r=ttung
Warning: found 11 untracked files (will not be submitted):
Submit to Phabricator (YES/No/Always)? 

h1. Expected behaviour

In the case described above, an output like the following would be nice (note the up-to-date prefix):

Inspecting 4 commits:
up-to-date (D40181) 543462:77ba5dc4fde9 Bug 1566758 - Replaced two uses of IDBFactory.open(name, options) by IDBFactory.open(name, version) where only version was present in options r=ttung
up-to-date (D40180) 543461:0c331ab6a500 Bug 1566758 - Added telemetry for use of IDBFactory.open(name, options) discriminated by principal types r=ttung
up-to-date (D40179) 543448:f94dacebf4cf Bug 1566758 - Remove obsolete telemetry definitions r=ttung
up-to-date (D40178) 543444:c8ca55504786 Bug 1566758 - Removed obsolete IDB_TYPE_PERSISTENT_COUNT and IDB_TYPE_TEMPORARY_COUNT telemetry r=ttung
No changes to submit, you are all set

or, in case I only changed the most recent 2 commits (note the up-to-date and modified prefixes):

Inspecting 4 commits:
modified (D40181) 543462:77ba5dc4fde9 Bug 1566758 - Replaced two uses of IDBFactory.open(name, options) by IDBFactory.open(name, version) where only version was present in options r=ttung
modified (D40180) 543461:0c331ab6a500 Bug 1566758 - Added telemetry for use of IDBFactory.open(name, options) discriminated by principal types r=ttung
up-to-date (D40179) 543448:f94dacebf4cf Bug 1566758 - Remove obsolete telemetry definitions r=ttung
up-to-date (D40178) 543444:c8ca55504786 Bug 1566758 - Removed obsolete IDB_TYPE_PERSISTENT_COUNT and IDB_TYPE_TEMPORARY_COUNT telemetry r=ttung
Submit 2 modified commits to Phabricator (YES/No/Always)? 

Comment 1

[:glob ✱]

unfortunately detecting unchanged commits locally can be complicated, especially following rebases.

Comment 2

[Simon Giesecke [:sg] [he/him]]

Sure, I can imagine this is hard in general, and probably not even possible with total accuracy. Maybe the special case that is probably easy, i.e. without an intermediate rebase as in my example above, should be split from the general case.